From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Tue, 21 Dec 2010 21:02:26 +0100 Subject: [U-Boot] [PATCH 1/3] lib/asm-offsets.c: Clean coding style In-Reply-To: <20101221185553.8A2E7126EB1A@gemini.denx.de> References: <1292955178-13018-1-git-send-email-monstr@monstr.eu> <20101221185553.8A2E7126EB1A@gemini.denx.de> Message-ID: <4D1107D2.7070607@monstr.eu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > Dear Michal Simek, > > In message <1292955178-13018-1-git-send-email-monstr@monstr.eu> you wrote: >> Clear coding style issues. >> >> Signed-off-by: Michal Simek >> --- >> lib/asm-offsets.c | 6 +++--- >> 1 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/lib/asm-offsets.c b/lib/asm-offsets.c >> index 2209561..f1af7e2 100644 >> --- a/lib/asm-offsets.c >> +++ b/lib/asm-offsets.c >> @@ -19,11 +19,11 @@ >> >> #include >> >> -int main(void) >> +int main (void) >> { >> /* Round up to make sure size gives nice stack alignment */ >> - DEFINE(GENERATED_GBL_DATA_SIZE, >> - (sizeof(struct global_data)+15) & ~15); >> + DEFINE (GENERATED_GBL_DATA_SIZE, >> + (sizeof (struct global_data) + 15) & ~15); > > These changes are to the worse. All. Why do you think this would be > better? It is what intend suggest to do. intend -npro -kr -i8 -ts8 -sob -l80 -ss -ncs -cp1 -pcs I am OK to remove space between macro name and argument as you suggested in your other email. >> + DEFINE (GENERATED_GBL_DATA_SIZE, >> + (sizeof (struct global_data) + 15) & ~15); ^ ^ ^ ^ I believe that marked space are OK, or not? Thanks, Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian