public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] remove (double) LED initialization in arm920t start.s
Date: Thu, 23 Dec 2010 14:18:00 +0100	[thread overview]
Message-ID: <4D134C08.8090609@emk-elektronik.de> (raw)
In-Reply-To: <20101223125121.3CA54152437@gemini.denx.de>

Dear Wolfgang Denk,
> Dear Reinhard Meyer,
>
> In message<4D1340BD.2090206@emk-elektronik.de>  you wrote:
>>
>> We should have one function like "show_status(int status)"
>> with various statuses defined like:
>> LED_STATUS_RESET, _BEFORE_RELOC, _AFTER_RELOC, _SENT_DHCP, _STARTING_KERNEL,
>> _CRASHED, ...
>
> Keep the existing code, and just turn the current set of numbers into
> an enum.

What current code?

1. show_boot_progress() is quite close, but has hundreds of values...
Not sure a enum would be useful there, the values have gaps; rather an
errno.h like implementation makes sense there.

2. the LED current code (in some non-ARM) places
has LED types (BOOT, ...) and LED modes (OFF, BLINK, ON).
That is totally different and quite useless for seven segment and
simple LCDisplays.

Best Regards,
Reinhard

  reply	other threads:[~2010-12-23 13:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-18 12:08 [U-Boot] [PATCH] remove (double) LED initialization in arm920t start.s Jens Scharsig
2010-12-23 11:58 ` Andreas Bießmann
2010-12-23 12:29   ` Reinhard Meyer
2010-12-23 12:51     ` Wolfgang Denk
2010-12-23 13:18       ` Reinhard Meyer [this message]
2010-12-23 15:05         ` Wolfgang Denk
2010-12-23 16:17 ` Jens Scharsig
2011-01-20 20:56 ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D134C08.8090609@emk-elektronik.de \
    --to=u-boot@emk-elektronik.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox