From mboxrd@z Thu Jan 1 00:00:00 1970 From: Reinhard Meyer Date: Thu, 23 Dec 2010 14:18:00 +0100 Subject: [U-Boot] [PATCH] remove (double) LED initialization in arm920t start.s In-Reply-To: <20101223125121.3CA54152437@gemini.denx.de> References: <4D0CA427.1070706@scharsoft.de> <4D1340BD.2090206@emk-elektronik.de> <20101223125121.3CA54152437@gemini.denx.de> Message-ID: <4D134C08.8090609@emk-elektronik.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang Denk, > Dear Reinhard Meyer, > > In message<4D1340BD.2090206@emk-elektronik.de> you wrote: >> >> We should have one function like "show_status(int status)" >> with various statuses defined like: >> LED_STATUS_RESET, _BEFORE_RELOC, _AFTER_RELOC, _SENT_DHCP, _STARTING_KERNEL, >> _CRASHED, ... > > Keep the existing code, and just turn the current set of numbers into > an enum. What current code? 1. show_boot_progress() is quite close, but has hundreds of values... Not sure a enum would be useful there, the values have gaps; rather an errno.h like implementation makes sense there. 2. the LED current code (in some non-ARM) places has LED types (BOOT, ...) and LED modes (OFF, BLINK, ON). That is totally different and quite useless for seven segment and simple LCDisplays. Best Regards, Reinhard