From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Mon, 27 Dec 2010 11:43:40 +0100
Subject: [U-Boot] [PATCH 2/3]  fsl_pmic: add I2C interface support
In-Reply-To: <1293024231-4897-2-git-send-email-r64343@freescale.com>
References: <1293024231-4897-1-git-send-email-r64343@freescale.com>
	<1293024231-4897-2-git-send-email-r64343@freescale.com>
Message-ID: <4D186DDC.2020100@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 12/22/2010 02:23 PM, Jason Liu wrote:
> This patch add I2C interface for fsl_pmic driver support
> 
> +#ifdef CONFIG_FSL_PMIC_I2C
> +#include <i2c.h>
> +static int init_done;
> +
> +u32 pmic_reg(u32 reg, u32 val, u32 write)
> +{
> +	unsigned char buf[4] = { 0 };
> +	u32 ret_val = 0;
> +
> +	if (reg > 63 || write > 1) {
> +		printf("<reg num> = %d is invalid. Should be less then 63\n",
> +			reg);
> +		return -1;
> +	}

Probably we can factorize better this function and do not duplicate the
pmic_reg function for SPI and I2C.

> +
> +	if (init_done == 0) {
> +		i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);
> +		init_done = 1;
> +	}
> +
> +	if (write) {
> +		buf[0] = (val >> 16) & 0xff;
> +		buf[1] = (val >> 8) & 0xff;
> +		buf[2] = (val) & 0xff;

It seems you are converting the endianess. No chance to use an already
provided accessor ?

> +		if (i2c_write(CONFIG_SYS_FSL_PMIC_I2C_ADDR, reg, 1, buf, 3))
> +			return -1;
> +	} else {
> +		if (i2c_read(CONFIG_SYS_FSL_PMIC_I2C_ADDR, reg, 1, buf, 3)) {
> +			return -1;
> +		ret_val = buf[0] << 16 | buf[1] << 8 | buf[2];

Ditto.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office@denx.de
=====================================================================