From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Mon, 27 Dec 2010 14:41:47 +0300 Subject: [U-Boot] [PATCH 15/28] Blackfin: fix bd_t handling In-Reply-To: <1293425300-27644-16-git-send-email-vapier@gentoo.org> References: <1293425300-27644-1-git-send-email-vapier@gentoo.org> <1293425300-27644-16-git-send-email-vapier@gentoo.org> Message-ID: <4D187B7B.70806@mvista.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello. On 27-12-2010 7:48, Mike Frysinger wrote: > The recent global data changes (making the size autogenerated) broke the > board info handling on Blackfin ports as we were lying and lumping the > bd_t size in with the gd_t size. So use the new dedicated bd_t size to > setup its own address in memory. > Signed-off-by: Mike Frysinger [...] > diff --git a/arch/blackfin/lib/board.c b/arch/blackfin/lib/board.c > index 2b1f78c..47d487f 100644 > --- a/arch/blackfin/lib/board.c > +++ b/arch/blackfin/lib/board.c [...] > @@ -244,14 +243,9 @@ void board_init_f(ulong bootflag) > gd = (gd_t *) (CONFIG_SYS_GBL_DATA_ADDR); > memset((void *)gd, 0, GENERATED_GBL_DATA_SIZE); > > - /* Board data initialization */ > - addr = (CONFIG_SYS_GBL_DATA_ADDR + sizeof(gd_t)); > - > - /* Align to 4 byte boundary */ > - addr&= ~(4 - 1); > - bd = (bd_t *) addr; > + bd = (bd_t *) (CONFIG_SYS_BD_INFO_ADDR); Parens not needed around CONFIG_SYS_BD_INFO_ADDR. WBR, Sergei