From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 7/8] imximage: Add MX53 boot image support
Date: Fri, 31 Dec 2010 10:35:38 +0100 [thread overview]
Message-ID: <4D1DA3EA.4060208@denx.de> (raw)
In-Reply-To: <20101231081015.91C6F4F1@gemini.denx.de>
On 12/31/2010 09:10 AM, Wolfgang Denk wrote:
> Dear Stefano Babic,
>
> In message <4D1C7F08.1010400@denx.de> you wrote:
>>
>> The name is not consistent with the other commands, as they do not use
>> the IMXIMAGE_ prefix (we do not have such as IMXIMAGE_BOOT_FROM). Please
>> replace with VERSION.
>
> No, plain "VERSION" is way too generic. We need some prefix here.
As the setting is only inside the imximage configuration file, I
supposed that it is redundant to remember we are talking about IMX
images and VERSION is self explaininig related to the file itself.
Jason has already set a prefix (IMXIMAGE_VERSION), so we can take it.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2010-12-31 9:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-29 12:49 [U-Boot] [PATCH v3 7/8] imximage: Add MX53 boot image support Jason Liu
2010-12-30 12:46 ` Stefano Babic
2010-12-31 3:29 ` Jason Liu
2010-12-31 6:06 ` Jason Liu
2010-12-31 8:14 ` Wolfgang Denk
2010-12-31 8:36 ` Jason Liu
2010-12-31 8:50 ` Wolfgang Denk
2010-12-31 9:25 ` Jason Liu
2010-12-31 10:03 ` Stefano Babic
2010-12-31 11:37 ` Wolfgang Denk
2010-12-31 9:48 ` Stefano Babic
2010-12-31 8:12 ` Wolfgang Denk
2010-12-31 9:55 ` Stefano Babic
2010-12-31 8:10 ` Wolfgang Denk
2010-12-31 9:35 ` Stefano Babic [this message]
2010-12-31 11:39 ` Wolfgang Denk
2010-12-31 12:47 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D1DA3EA.4060208@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox