From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Fri, 31 Dec 2010 10:35:38 +0100 Subject: [U-Boot] [PATCH v3 7/8] imximage: Add MX53 boot image support In-Reply-To: <20101231081015.91C6F4F1@gemini.denx.de> References: <1293626967-18740-1-git-send-email-r64343@freescale.com> <4D1C7F08.1010400@denx.de> <20101231081015.91C6F4F1@gemini.denx.de> Message-ID: <4D1DA3EA.4060208@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/31/2010 09:10 AM, Wolfgang Denk wrote: > Dear Stefano Babic, > > In message <4D1C7F08.1010400@denx.de> you wrote: >> >> The name is not consistent with the other commands, as they do not use >> the IMXIMAGE_ prefix (we do not have such as IMXIMAGE_BOOT_FROM). Please >> replace with VERSION. > > No, plain "VERSION" is way too generic. We need some prefix here. As the setting is only inside the imximage configuration file, I supposed that it is redundant to remember we are talking about IMX images and VERSION is self explaininig related to the file itself. Jason has already set a prefix (IMXIMAGE_VERSION), so we can take it. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================