[U-Boot] Recent changes break our update scripts, because of getenv_yesno()

[Stefano Babic <sbabic@denx.de>]

On 12/31/2010 11:33 AM, Reinhard Meyer wrote:
> Hello,
> 
> in common/image.c:
> 
> 
> int getenv_yesno (char *var)
> {
> 	char *s = getenv (var);
> 	return (s && (*s == 'n')) ? 0 : 1;
> }
> 
> Is that supposed to return TRUE when the env variable does NOT exist?
> 
> Because each TFTP/USB/whatever load of an image will automatically start it!

You are right. I am stucking with the same issue, and inverting the test
makes things working again.

However, I see this behavior only with 2010.12 and the suspicious
function is really old, I am wondering why we see this behavior only now.

> 
> (and why is such a generic function in image.c?)

Another good point...

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================