public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Recent changes break our update scripts, because of getenv_yesno()
Date: Fri, 31 Dec 2010 11:58:19 +0100	[thread overview]
Message-ID: <4D1DB74B.9000901@denx.de> (raw)
In-Reply-To: <4D1DB35A.3090105@emk-elektronik.de>

On 12/31/2010 11:41 AM, Reinhard Meyer wrote:

>          /* Loading ok, check if we should attempt an auto-start */
> -       if (((s = getenv("autostart")) != NULL) && (strcmp(s,"yes") == 0)) {
> +       if (getenv_yesno("autostart")) {
>                  char *local_args[2];
>                  local_args[0] = argv[0];
>                  local_args[1] = NULL;
> 
> Originally, a missing env var resulted in FALSE, with the helper function it
> results in TRUE!!

Thanks, this explains why it happens ! We should check again for a
missing env var.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2010-12-31 10:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-31 10:33 [U-Boot] Recent changes break our update scripts, because of getenv_yesno() Reinhard Meyer
2010-12-31 10:41 ` Reinhard Meyer
2010-12-31 10:58   ` Stefano Babic [this message]
2010-12-31 11:42   ` Wolfgang Denk
2010-12-31 11:54     ` Reinhard Meyer
2010-12-31 17:59       ` Mike Frysinger
2010-12-31 10:55 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D1DB74B.9000901@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox