public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] S3C64XX: timer: replace bss variable by gd
Date: Thu, 06 Jan 2011 09:53:10 +0100	[thread overview]
Message-ID: <4D2582F6.2040909@emk-elektronik.de> (raw)
In-Reply-To: <AANLkTikBc9FPwevrmWouaTfiGYtW1UQevCOe8NM8Pgr5@mail.gmail.com>

Dear concerned,
>>>>>> Use the global data instead of bss variable, replace as follow.
>>>>>> timer_load_val ->     timer_rate_hz
>>>>>> timestamp ->     timer_reset_value

I am not too happy about this "misuse" of gd->variables making them
"misnomers" and the code harder to read.

timer_rate_hz is supposed to hold the rate at which the high
speed timer increments.

timer_reset_value supposedly holds the high speed timer's value when
timer_reset() is called.

There was a discussion started about this a while ago, but came to no
conclusion...

Best Regards,
Reinhard

  reply	other threads:[~2011-01-06  8:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-04  8:14 [U-Boot] [PATCH] S3C64XX: timer: replace bss variable by gd Minkyu Kang
2011-01-04 14:46 ` seedshope
2011-01-04 14:56   ` seedshope
2011-01-05  7:04     ` Minkyu Kang
2011-01-05 15:57       ` seedshope
2011-01-06  8:34         ` Minkyu Kang
2011-01-06  8:53           ` Reinhard Meyer [this message]
2011-01-09 16:20             ` Wolfgang Denk
2011-01-09 16:14 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D2582F6.2040909@emk-elektronik.de \
    --to=u-boot@emk-elektronik.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox