* [U-Boot] [PATCH 1/3] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared
@ 2011-01-07 15:53 seedshope
2011-01-07 15:53 ` [U-Boot] [PATCH 2/3] SMDK6400:use common arm1176 u-boot.lds of cpu layer seedshope
` (2 more replies)
0 siblings, 3 replies; 17+ messages in thread
From: seedshope @ 2011-01-07 15:53 UTC (permalink / raw)
To: u-boot
From: seedshope <bocui107@gmail.com>
CONFIG_SYS_INIT_SP_ADDR point the last PHY of IRAM
and substract the global size.
Signed-off-by: seedshope <bocui107@googlemail.com>
diff --git a/include/configs/smdk6400.h b/include/configs/smdk6400.h
index 671f2c7..037db4f 100644
--- a/include/configs/smdk6400.h
+++ b/include/configs/smdk6400.h
@@ -174,6 +174,11 @@
#define PHYS_SDRAM_1 CONFIG_SYS_SDRAM_BASE /* SDRAM Bank #1 */
#define PHYS_SDRAM_1_SIZE 0x08000000 /* 128 MB in Bank #1 */
+#define CONFIG_SYS_IRAM_BASE 0x0c000000 /* Internal SRAM base address */
+#define CONFIG_SYS_IRAM_SIZE 0x2000 /* 8 KB of internal SRAM memory */
+#define CONFIG_SYS_IRAM_END (CONFIG_SYS_IRAM_BASE + CONFIG_SYS_IRAM_SIZE)
+#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_IRAM_END - GENERATED_GBL_DATA_SIZE)
+
#define CONFIG_SYS_FLASH_BASE 0x10000000
#define CONFIG_SYS_MONITOR_BASE 0x00000000
--
1.7.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* [U-Boot] [PATCH 2/3] SMDK6400:use common arm1176 u-boot.lds of cpu layer 2011-01-07 15:53 [U-Boot] [PATCH 1/3] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared seedshope @ 2011-01-07 15:53 ` seedshope 2011-01-08 6:04 ` Albert ARIBAUD 2011-01-07 15:53 ` [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support seedshope 2011-01-08 5:55 ` [U-Boot] [PATCH 1/3] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared Albert ARIBAUD 2 siblings, 1 reply; 17+ messages in thread From: seedshope @ 2011-01-07 15:53 UTC (permalink / raw) To: u-boot From: seedshope <bocui107@gmail.com> Remove u-boot-nand.lds from board/samsung/smdk6400 and use the common u-boot.lds of arm1176 cpu layer. This patch also fix the building errors: arch/arm/cpu/arm1176/s3c64xx/libs3c64xx.o: In function `mem_ctrl_asm_init': arch/arm/cpu/arm1176/s3c64xx/cpu_init.S:32: multiple definition of `mem_ctrl_asm_init' arch/arm/cpu/arm1176/s3c64xx/cpu_init.S:32: first defined here arch/arm/cpu/arm1176/start.o: In function `_rel_dyn_start_ofs': arch/arm/cpu/arm1176/start.S:379: undefined reference to `__rel_dyn_start' arch/arm/cpu/arm1176/start.o: In function `_rel_dyn_end_ofs': arch/arm/cpu/arm1176/start.S:379: undefined reference to `__rel_dyn_end' arch/arm/cpu/arm1176/start.o: In function `_dynsym_start_ofs': arch/arm/cpu/arm1176/start.S:379: undefined reference to `__dynsym_start' Signed-off-by: seedshope <bocui107@googlemail.com> diff --git a/board/samsung/smdk6400/config.mk b/board/samsung/smdk6400/config.mk index 90cbcf2..0443f60 100644 --- a/board/samsung/smdk6400/config.mk +++ b/board/samsung/smdk6400/config.mk @@ -29,4 +29,3 @@ else CONFIG_SYS_TEXT_BASE = 0 endif -LDSCRIPT := $(SRCTREE)/board/$(BOARDDIR)/u-boot-nand.lds diff --git a/board/samsung/smdk6400/u-boot-nand.lds b/board/samsung/smdk6400/u-boot-nand.lds deleted file mode 100644 index 29a4f61..0000000 --- a/board/samsung/smdk6400/u-boot-nand.lds +++ /dev/null @@ -1,62 +0,0 @@ -/* - * (C) Copyright 2002 - * Gary Jennejohn, DENX Software Engineering, <garyj@denx.de> - * - * (C) Copyright 2008 - * Guennadi Liakhovetki, DENX Software Engineering, <lg@denx.de> - * - * See file CREDITS for list of people who contributed to this - * project. - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; either version 2 of - * the License, or (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, - * MA 02111-1307 USA - */ - -OUTPUT_FORMAT("elf32-littlearm", "elf32-littlearm", "elf32-littlearm") -OUTPUT_ARCH(arm) -ENTRY(_start) -SECTIONS -{ - . = 0x00000000; - - . = ALIGN(4); - .text : - { - arch/arm/cpu/arm1176/start.o (.text) - arch/arm/cpu/arm1176/s3c64xx/cpu_init.o (.text) - *(.text) - } - - . = ALIGN(4); - .rodata : { *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*))) } - - . = ALIGN(4); - .data : { *(.data) } - - . = ALIGN(4); - .got : { *(.got) } - - __u_boot_cmd_start = .; - .u_boot_cmd : { *(.u_boot_cmd) } - __u_boot_cmd_end = .; - - . = ALIGN(4); - .mmudata : { *(.mmudata) } - - . = ALIGN(4); - __bss_start = .; - .bss : { *(.bss) . = ALIGN(4); } - _end = .; -} -- 1.7.1 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH 2/3] SMDK6400:use common arm1176 u-boot.lds of cpu layer 2011-01-07 15:53 ` [U-Boot] [PATCH 2/3] SMDK6400:use common arm1176 u-boot.lds of cpu layer seedshope @ 2011-01-08 6:04 ` Albert ARIBAUD 2011-01-08 14:54 ` seedshope 0 siblings, 1 reply; 17+ messages in thread From: Albert ARIBAUD @ 2011-01-08 6:04 UTC (permalink / raw) To: u-boot Le 07/01/2011 16:53, seedshope a ?crit : > From: seedshope<bocui107@gmail.com> > > Remove u-boot-nand.lds from board/samsung/smdk6400 and > use the common u-boot.lds of arm1176 cpu layer. This > patch also fix the building errors: > > arch/arm/cpu/arm1176/s3c64xx/libs3c64xx.o: In function `mem_ctrl_asm_init': > arch/arm/cpu/arm1176/s3c64xx/cpu_init.S:32: multiple definition of `mem_ctrl_asm_init' > arch/arm/cpu/arm1176/s3c64xx/cpu_init.S:32: first defined here > arch/arm/cpu/arm1176/start.o: In function `_rel_dyn_start_ofs': > arch/arm/cpu/arm1176/start.S:379: undefined reference to `__rel_dyn_start' > arch/arm/cpu/arm1176/start.o: In function `_rel_dyn_end_ofs': > arch/arm/cpu/arm1176/start.S:379: undefined reference to `__rel_dyn_end' > arch/arm/cpu/arm1176/start.o: In function `_dynsym_start_ofs': > arch/arm/cpu/arm1176/start.S:379: undefined reference to `__dynsym_start' > > Signed-off-by: seedshope<bocui107@googlemail.com> In the current u-boot-arm tree, board/samsung/smdk6400/u-boot-nand.lds and arch/arm/cpu/arm1176/u-boot.lds are identical; I am thus ok with the change in itself since the board lds file was useless, but I am not sure the description is valid. Can you double-check this change wrt to the link issue? Amicalement, -- Albert. ^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH 2/3] SMDK6400:use common arm1176 u-boot.lds of cpu layer 2011-01-08 6:04 ` Albert ARIBAUD @ 2011-01-08 14:54 ` seedshope 0 siblings, 0 replies; 17+ messages in thread From: seedshope @ 2011-01-08 14:54 UTC (permalink / raw) To: u-boot On 01/08/2011 02:04 PM, Albert ARIBAUD wrote: > Le 07/01/2011 16:53, seedshope a ?crit : >> From: seedshope<bocui107@gmail.com> >> >> Remove u-boot-nand.lds from board/samsung/smdk6400 and >> use the common u-boot.lds of arm1176 cpu layer. This >> patch also fix the building errors: >> >> arch/arm/cpu/arm1176/s3c64xx/libs3c64xx.o: In function `mem_ctrl_asm_init': >> arch/arm/cpu/arm1176/s3c64xx/cpu_init.S:32: multiple definition of `mem_ctrl_asm_init' >> arch/arm/cpu/arm1176/s3c64xx/cpu_init.S:32: first defined here >> arch/arm/cpu/arm1176/start.o: In function `_rel_dyn_start_ofs': >> arch/arm/cpu/arm1176/start.S:379: undefined reference to `__rel_dyn_start' >> arch/arm/cpu/arm1176/start.o: In function `_rel_dyn_end_ofs': >> arch/arm/cpu/arm1176/start.S:379: undefined reference to `__rel_dyn_end' >> arch/arm/cpu/arm1176/start.o: In function `_dynsym_start_ofs': >> arch/arm/cpu/arm1176/start.S:379: undefined reference to `__dynsym_start' >> >> Signed-off-by: seedshope<bocui107@googlemail.com> > In the current u-boot-arm tree, board/samsung/smdk6400/u-boot-nand.lds > and arch/arm/cpu/arm1176/u-boot.lds are identical; I am thus ok with the > change in itself since the board lds file was useless, but I am not sure > the description is valid. Can you double-check this change wrt to the > link issue? I am sure the link issue. But I need to adjust the patch. I should be modify base on board/samsung/smdk6400/u-boot-nand.lds, Don't delete it. > Amicalement, ^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support 2011-01-07 15:53 [U-Boot] [PATCH 1/3] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared seedshope 2011-01-07 15:53 ` [U-Boot] [PATCH 2/3] SMDK6400:use common arm1176 u-boot.lds of cpu layer seedshope @ 2011-01-07 15:53 ` seedshope 2011-01-08 6:14 ` Albert ARIBAUD 2011-01-08 15:15 ` Minkyu Kang 2011-01-08 5:55 ` [U-Boot] [PATCH 1/3] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared Albert ARIBAUD 2 siblings, 2 replies; 17+ messages in thread From: seedshope @ 2011-01-07 15:53 UTC (permalink / raw) To: u-boot From: seedshope <bocui107@gmail.com> Modify u-boot.lds from nand_spl/board/samsung/smdk6400. start.o: In function `clbss_l': nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to `coloured_LED_init' nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to `red_LED_on' start.o: In function `_rel_dyn_start_ofs': nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_start' start.o: In function `_rel_dyn_end_ofs': nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_end' start.o: In function `_dynsym_start_ofs': nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__dynsym_start' Signed-off-by: seedshope <bocui107@googlemail.com> diff --git a/arch/arm/cpu/arm1176/start.S b/arch/arm/cpu/arm1176/start.S index 237dcfe..bde0357 100644 --- a/arch/arm/cpu/arm1176/start.S +++ b/arch/arm/cpu/arm1176/start.S @@ -353,10 +353,11 @@ clbss_l:str r2, [r0] /* clear loop... */ add r0, r0, #4 cmp r0, r1 bne clbss_l - +#ifndef CONFIG_NAND_SPL bl coloured_LED_init bl red_LED_on #endif +#endif /* * We are done. Do not return, instead branch to second part of board diff --git a/nand_spl/board/samsung/smdk6400/u-boot.lds b/nand_spl/board/samsung/smdk6400/u-boot.lds index 3ac6aa1..c179db3 100644 --- a/nand_spl/board/samsung/smdk6400/u-boot.lds +++ b/nand_spl/board/samsung/smdk6400/u-boot.lds @@ -54,8 +54,23 @@ SECTIONS .u_boot_cmd : { *(.u_boot_cmd) } __u_boot_cmd_end = .; - . = ALIGN(4); - __bss_start = .; - .bss : { *(.bss) . = ALIGN(4); } - _end = .; + . = ALIGN(4); + + .rel.dyn : { + __rel_dyn_start = .; + *(.rel*) + __rel_dyn_end = .; + } + + .dynsym : { + __dynsym_start = .; + *(.dynsym) + } + + .bss __rel_dyn_start (OVERLAY) : { + __bss_start = .; + *(.bss) + . = ALIGN(4); + _end = .; + } } -- 1.7.1 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support 2011-01-07 15:53 ` [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support seedshope @ 2011-01-08 6:14 ` Albert ARIBAUD 2011-01-08 14:57 ` seedshope 2011-01-08 15:15 ` Minkyu Kang 1 sibling, 1 reply; 17+ messages in thread From: Albert ARIBAUD @ 2011-01-08 6:14 UTC (permalink / raw) To: u-boot Hi seedshope, Le 07/01/2011 16:53, seedshope a ?crit : > From: seedshope<bocui107@gmail.com> > > Modify u-boot.lds from nand_spl/board/samsung/smdk6400. You're also modifying start.S. If you mention files in the patch summary, then please mention them all. > start.o: In function `clbss_l': > nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to `coloured_LED_init' > nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to `red_LED_on' > start.o: In function `_rel_dyn_start_ofs': > nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_start' > start.o: In function `_rel_dyn_end_ofs': > nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_end' > start.o: In function `_dynsym_start_ofs': > nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__dynsym_start' > > Signed-off-by: seedshope<bocui107@googlemail.com> Please limit the commit message to a simple explanation of the issue fixed, without pasting detailed build messages int it. Here for instance you need only indicate that you're removing references to relocation symbols and calls to LED functions. Amicalement, -- Albert. ^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support 2011-01-08 6:14 ` Albert ARIBAUD @ 2011-01-08 14:57 ` seedshope 0 siblings, 0 replies; 17+ messages in thread From: seedshope @ 2011-01-08 14:57 UTC (permalink / raw) To: u-boot On 01/08/2011 02:14 PM, Albert ARIBAUD wrote: > Hi seedshope, > > Le 07/01/2011 16:53, seedshope a ?crit : >> From: seedshope<bocui107@gmail.com> >> >> Modify u-boot.lds from nand_spl/board/samsung/smdk6400. > You're also modifying start.S. If you mention files in the patch > summary, then please mention them all. ok >> start.o: In function `clbss_l': >> nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to `coloured_LED_init' >> nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to `red_LED_on' >> start.o: In function `_rel_dyn_start_ofs': >> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_start' >> start.o: In function `_rel_dyn_end_ofs': >> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_end' >> start.o: In function `_dynsym_start_ofs': >> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__dynsym_start' >> >> Signed-off-by: seedshope<bocui107@googlemail.com> > Please limit the commit message to a simple explanation of the issue > fixed, without pasting detailed build messages int it. Here for instance > you need only indicate that you're removing references to relocation > symbols and calls to LED functions. ok Thanks, seedshope > Amicalement, ^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support 2011-01-07 15:53 ` [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support seedshope 2011-01-08 6:14 ` Albert ARIBAUD @ 2011-01-08 15:15 ` Minkyu Kang 2011-01-09 1:14 ` seedshope 1 sibling, 1 reply; 17+ messages in thread From: Minkyu Kang @ 2011-01-08 15:15 UTC (permalink / raw) To: u-boot Dear seedshope, On 8 January 2011 00:53, seedshope <bocui107@gmail.com> wrote: > From: seedshope <bocui107@gmail.com> > > Modify u-boot.lds from nand_spl/board/samsung/smdk6400. > > start.o: In function `clbss_l': > nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to `coloured_LED_init' > nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to `red_LED_on' > start.o: In function `_rel_dyn_start_ofs': > nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_start' > start.o: In function `_rel_dyn_end_ofs': > nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_end' > start.o: In function `_dynsym_start_ofs': > nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__dynsym_start' > > Signed-off-by: seedshope <bocui107@googlemail.com> > > diff --git a/arch/arm/cpu/arm1176/start.S b/arch/arm/cpu/arm1176/start.S > index 237dcfe..bde0357 100644 > --- a/arch/arm/cpu/arm1176/start.S > +++ b/arch/arm/cpu/arm1176/start.S > @@ -353,10 +353,11 @@ clbss_l:str ? ? ? r2, [r0] ? ? ? ? ? ? ? ?/* clear loop... ? ? ? ? ? ? ? ? ? ?*/ > ? ? ? ?add ? ? r0, r0, #4 > ? ? ? ?cmp ? ? r0, r1 > ? ? ? ?bne ? ? clbss_l > - > +#ifndef CONFIG_NAND_SPL CONFIG_PRELOADER is better > ? ? ? ?bl coloured_LED_init > ? ? ? ?bl red_LED_on > ?#endif > +#endif > > ?/* Thanks Minkyu Kang -- from. prom. www.promsoft.net ^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support 2011-01-08 15:15 ` Minkyu Kang @ 2011-01-09 1:14 ` seedshope 2011-01-09 7:33 ` Minkyu Kang 0 siblings, 1 reply; 17+ messages in thread From: seedshope @ 2011-01-09 1:14 UTC (permalink / raw) To: u-boot On 01/08/2011 11:15 PM, Minkyu Kang wrote: > Dear seedshope, > > On 8 January 2011 00:53, seedshope<bocui107@gmail.com> wrote: >> From: seedshope<bocui107@gmail.com> >> >> Modify u-boot.lds from nand_spl/board/samsung/smdk6400. >> >> start.o: In function `clbss_l': >> nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to `coloured_LED_init' >> nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to `red_LED_on' >> start.o: In function `_rel_dyn_start_ofs': >> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_start' >> start.o: In function `_rel_dyn_end_ofs': >> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_end' >> start.o: In function `_dynsym_start_ofs': >> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__dynsym_start' >> >> Signed-off-by: seedshope<bocui107@googlemail.com> >> >> diff --git a/arch/arm/cpu/arm1176/start.S b/arch/arm/cpu/arm1176/start.S >> index 237dcfe..bde0357 100644 >> --- a/arch/arm/cpu/arm1176/start.S >> +++ b/arch/arm/cpu/arm1176/start.S >> @@ -353,10 +353,11 @@ clbss_l:str r2, [r0] /* clear loop... */ >> add r0, r0, #4 >> cmp r0, r1 >> bne clbss_l >> - >> +#ifndef CONFIG_NAND_SPL > CONFIG_PRELOADER is better No, The nand_spl support can't find the define of coloured_LED_init and red_LED_on. It is base on the build error: make smdk6400_config make the error information as following: nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to `coloured_LED_init' nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to `red_LED_on' Thanks, seedshope >> bl coloured_LED_init >> bl red_LED_on >> #endif >> +#endif >> >> /* > Thanks > Minkyu Kang ^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support 2011-01-09 1:14 ` seedshope @ 2011-01-09 7:33 ` Minkyu Kang 2011-01-09 12:27 ` seedshope 0 siblings, 1 reply; 17+ messages in thread From: Minkyu Kang @ 2011-01-09 7:33 UTC (permalink / raw) To: u-boot Hi On 9 January 2011 10:14, seedshope <bocui107@gmail.com> wrote: > On 01/08/2011 11:15 PM, Minkyu Kang wrote: >> >> Dear seedshope, >> >> On 8 January 2011 00:53, seedshope<bocui107@gmail.com> ?wrote: >>> >>> From: seedshope<bocui107@gmail.com> >>> >>> Modify u-boot.lds from nand_spl/board/samsung/smdk6400. >>> >>> start.o: In function `clbss_l': >>> nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to >>> `coloured_LED_init' >>> nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to >>> `red_LED_on' >>> start.o: In function `_rel_dyn_start_ofs': >>> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to >>> `__rel_dyn_start' >>> start.o: In function `_rel_dyn_end_ofs': >>> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to >>> `__rel_dyn_end' >>> start.o: In function `_dynsym_start_ofs': >>> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to >>> `__dynsym_start' >>> >>> Signed-off-by: seedshope<bocui107@googlemail.com> >>> >>> diff --git a/arch/arm/cpu/arm1176/start.S b/arch/arm/cpu/arm1176/start.S >>> index 237dcfe..bde0357 100644 >>> --- a/arch/arm/cpu/arm1176/start.S >>> +++ b/arch/arm/cpu/arm1176/start.S >>> @@ -353,10 +353,11 @@ clbss_l:str ? ? ? r2, [r0] ? ? ? ? ? ? ? ?/* clear >>> loop... ? ? ? ? ? ? ? ? ? ?*/ >>> ? ? ? ?add ? ? r0, r0, #4 >>> ? ? ? ?cmp ? ? r0, r1 >>> ? ? ? ?bne ? ? clbss_l >>> - >>> +#ifndef CONFIG_NAND_SPL >> >> CONFIG_PRELOADER is better > > No, The nand_spl support can't find the define of coloured_LED_init and > red_LED_on. > It is base on the build error: > > make smdk6400_config > make > the error information as following: > > nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to > `coloured_LED_init' > nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to > `red_LED_on' > Please add follow define at Makefile. AFLAGS += -DCONFIG_PRELOADER -DCONFIG_NAND_SPL CFLAGS += -DCONFIG_PRELOADER -DCONFIG_NAND_SPL Thanks Minkyu Kang -- from. prom. www.promsoft.net ^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support 2011-01-09 7:33 ` Minkyu Kang @ 2011-01-09 12:27 ` seedshope 2011-01-09 14:12 ` Minkyu Kang 0 siblings, 1 reply; 17+ messages in thread From: seedshope @ 2011-01-09 12:27 UTC (permalink / raw) To: u-boot On 01/09/2011 03:33 PM, Minkyu Kang wrote: > Hi > > On 9 January 2011 10:14, seedshope<bocui107@gmail.com> wrote: >> On 01/08/2011 11:15 PM, Minkyu Kang wrote: >>> Dear seedshope, >>> >>> On 8 January 2011 00:53, seedshope<bocui107@gmail.com> wrote: >>>> From: seedshope<bocui107@gmail.com> >>>> >>>> Modify u-boot.lds from nand_spl/board/samsung/smdk6400. >>>> >>>> start.o: In function `clbss_l': >>>> nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to >>>> `coloured_LED_init' >>>> nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to >>>> `red_LED_on' >>>> start.o: In function `_rel_dyn_start_ofs': >>>> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to >>>> `__rel_dyn_start' >>>> start.o: In function `_rel_dyn_end_ofs': >>>> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to >>>> `__rel_dyn_end' >>>> start.o: In function `_dynsym_start_ofs': >>>> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to >>>> `__dynsym_start' >>>> >>>> Signed-off-by: seedshope<bocui107@googlemail.com> >>>> >>>> diff --git a/arch/arm/cpu/arm1176/start.S b/arch/arm/cpu/arm1176/start.S >>>> index 237dcfe..bde0357 100644 >>>> --- a/arch/arm/cpu/arm1176/start.S >>>> +++ b/arch/arm/cpu/arm1176/start.S >>>> @@ -353,10 +353,11 @@ clbss_l:str r2, [r0] /* clear >>>> loop... */ >>>> add r0, r0, #4 >>>> cmp r0, r1 >>>> bne clbss_l >>>> - >>>> +#ifndef CONFIG_NAND_SPL >>> CONFIG_PRELOADER is better >> No, The nand_spl support can't find the define of coloured_LED_init and >> red_LED_on. >> It is base on the build error: >> >> make smdk6400_config >> make >> the error information as following: >> >> nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to >> `coloured_LED_init' >> nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to >> `red_LED_on' >> > Please add follow define at Makefile. > AFLAGS += -DCONFIG_PRELOADER -DCONFIG_NAND_SPL > CFLAGS += -DCONFIG_PRELOADER -DCONFIG_NAND_SPL ok, It may be a good method. But I worried other people will be difficult to see the process of the code running. So, if add #ifdef CONFIG_NAND_SPL, It is very clear. What do you think about it? Thanks, seedshope > Thanks > Minkyu Kang ^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support 2011-01-09 12:27 ` seedshope @ 2011-01-09 14:12 ` Minkyu Kang 2011-01-09 14:52 ` seedshope 0 siblings, 1 reply; 17+ messages in thread From: Minkyu Kang @ 2011-01-09 14:12 UTC (permalink / raw) To: u-boot Hello, On 9 January 2011 21:27, seedshope <bocui107@gmail.com> wrote: > On 01/09/2011 03:33 PM, Minkyu Kang wrote: >> >> Hi >> >> On 9 January 2011 10:14, seedshope<bocui107@gmail.com> ?wrote: >>> >>> On 01/08/2011 11:15 PM, Minkyu Kang wrote: >>>> >>>> Dear seedshope, >>>> >>>> On 8 January 2011 00:53, seedshope<bocui107@gmail.com> ? ?wrote: >>>>> >>>>> From: seedshope<bocui107@gmail.com> >>>>> >>>>> Modify u-boot.lds from nand_spl/board/samsung/smdk6400. >>>>> >>>>> start.o: In function `clbss_l': >>>>> nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to >>>>> `coloured_LED_init' >>>>> nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to >>>>> `red_LED_on' >>>>> start.o: In function `_rel_dyn_start_ofs': >>>>> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to >>>>> `__rel_dyn_start' >>>>> start.o: In function `_rel_dyn_end_ofs': >>>>> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to >>>>> `__rel_dyn_end' >>>>> start.o: In function `_dynsym_start_ofs': >>>>> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to >>>>> `__dynsym_start' >>>>> >>>>> Signed-off-by: seedshope<bocui107@googlemail.com> >>>>> >>>>> diff --git a/arch/arm/cpu/arm1176/start.S >>>>> b/arch/arm/cpu/arm1176/start.S >>>>> index 237dcfe..bde0357 100644 >>>>> --- a/arch/arm/cpu/arm1176/start.S >>>>> +++ b/arch/arm/cpu/arm1176/start.S >>>>> @@ -353,10 +353,11 @@ clbss_l:str ? ? ? r2, [r0] ? ? ? ? ? ? ? ?/* >>>>> clear >>>>> loop... ? ? ? ? ? ? ? ? ? ?*/ >>>>> ? ? ? ?add ? ? r0, r0, #4 >>>>> ? ? ? ?cmp ? ? r0, r1 >>>>> ? ? ? ?bne ? ? clbss_l >>>>> - >>>>> +#ifndef CONFIG_NAND_SPL >>>> >>>> CONFIG_PRELOADER is better >>> >>> No, The nand_spl support can't find the define of coloured_LED_init and >>> red_LED_on. >>> It is base on the build error: >>> >>> make smdk6400_config >>> make >>> the error information as following: >>> >>> nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to >>> `coloured_LED_init' >>> nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to >>> `red_LED_on' >>> >> Please add follow define at Makefile. >> AFLAGS ?+= -DCONFIG_PRELOADER -DCONFIG_NAND_SPL >> CFLAGS ?+= -DCONFIG_PRELOADER -DCONFIG_NAND_SPL > > ok, It may be a good method. > > But I worried other people will be difficult ?to see the process of the code > running. > So, if add #ifdef ?CONFIG_NAND_SPL, It is very clear. What do you think > about it? > Ah, already used CONFIG_NAND_SPL at start.S. OK, we can do this work (change from CONFIG_NAND_SPL to CONFIG_PRELOADER) at another patch. Thanks Minkyu Kang -- from. prom. www.promsoft.net ^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support 2011-01-09 14:12 ` Minkyu Kang @ 2011-01-09 14:52 ` seedshope 0 siblings, 0 replies; 17+ messages in thread From: seedshope @ 2011-01-09 14:52 UTC (permalink / raw) To: u-boot On 01/09/2011 10:12 PM, Minkyu Kang wrote: > Hello, > > On 9 January 2011 21:27, seedshope<bocui107@gmail.com> wrote: >> On 01/09/2011 03:33 PM, Minkyu Kang wrote: >>> Hi >>> >>> On 9 January 2011 10:14, seedshope<bocui107@gmail.com> wrote: >>>> On 01/08/2011 11:15 PM, Minkyu Kang wrote: >>>>> Dear seedshope, >>>>> >>>>> On 8 January 2011 00:53, seedshope<bocui107@gmail.com> wrote: >>>>>> From: seedshope<bocui107@gmail.com> >>>>>> >>>>>> Modify u-boot.lds from nand_spl/board/samsung/smdk6400. >>>>>> >>>>>> start.o: In function `clbss_l': >>>>>> nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to >>>>>> `coloured_LED_init' >>>>>> nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to >>>>>> `red_LED_on' >>>>>> start.o: In function `_rel_dyn_start_ofs': >>>>>> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to >>>>>> `__rel_dyn_start' >>>>>> start.o: In function `_rel_dyn_end_ofs': >>>>>> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to >>>>>> `__rel_dyn_end' >>>>>> start.o: In function `_dynsym_start_ofs': >>>>>> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to >>>>>> `__dynsym_start' >>>>>> >>>>>> Signed-off-by: seedshope<bocui107@googlemail.com> >>>>>> >>>>>> diff --git a/arch/arm/cpu/arm1176/start.S >>>>>> b/arch/arm/cpu/arm1176/start.S >>>>>> index 237dcfe..bde0357 100644 >>>>>> --- a/arch/arm/cpu/arm1176/start.S >>>>>> +++ b/arch/arm/cpu/arm1176/start.S >>>>>> @@ -353,10 +353,11 @@ clbss_l:str r2, [r0] /* >>>>>> clear >>>>>> loop... */ >>>>>> add r0, r0, #4 >>>>>> cmp r0, r1 >>>>>> bne clbss_l >>>>>> - >>>>>> +#ifndef CONFIG_NAND_SPL >>>>> CONFIG_PRELOADER is better >>>> No, The nand_spl support can't find the define of coloured_LED_init and >>>> red_LED_on. >>>> It is base on the build error: >>>> >>>> make smdk6400_config >>>> make >>>> the error information as following: >>>> >>>> nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to >>>> `coloured_LED_init' >>>> nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to >>>> `red_LED_on' >>>> >>> Please add follow define at Makefile. >>> AFLAGS += -DCONFIG_PRELOADER -DCONFIG_NAND_SPL >>> CFLAGS += -DCONFIG_PRELOADER -DCONFIG_NAND_SPL >> ok, It may be a good method. >> >> But I worried other people will be difficult to see the process of the code >> running. >> So, if add #ifdef CONFIG_NAND_SPL, It is very clear. What do you think >> about it? >> > Ah, already used CONFIG_NAND_SPL at start.S. > OK, we can do this work (change from CONFIG_NAND_SPL to > CONFIG_PRELOADER) at another patch. Ok, I will send RR2 for SMDK6400 relate patch. Thanks, seedshope > Thanks > Minkyu Kang ^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH 1/3] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared 2011-01-07 15:53 [U-Boot] [PATCH 1/3] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared seedshope 2011-01-07 15:53 ` [U-Boot] [PATCH 2/3] SMDK6400:use common arm1176 u-boot.lds of cpu layer seedshope 2011-01-07 15:53 ` [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support seedshope @ 2011-01-08 5:55 ` Albert ARIBAUD 2011-01-08 15:10 ` seedshope 2 siblings, 1 reply; 17+ messages in thread From: Albert ARIBAUD @ 2011-01-08 5:55 UTC (permalink / raw) To: u-boot Le 07/01/2011 16:53, seedshope a ?crit : > From: seedshope<bocui107@gmail.com> > > CONFIG_SYS_INIT_SP_ADDR point the last PHY of IRAM > and substract the global size. > > Signed-off-by: seedshope<bocui107@googlemail.com> Please fix the From: line in all patches in this set; it should not appear in the long commit message. Amicalement, -- Albert. ^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH 1/3] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared 2011-01-08 5:55 ` [U-Boot] [PATCH 1/3] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared Albert ARIBAUD @ 2011-01-08 15:10 ` seedshope 2011-01-08 15:17 ` Albert ARIBAUD 0 siblings, 1 reply; 17+ messages in thread From: seedshope @ 2011-01-08 15:10 UTC (permalink / raw) To: u-boot On 01/08/2011 01:55 PM, Albert ARIBAUD wrote: > Le 07/01/2011 16:53, seedshope a ?crit : >> From: seedshope<bocui107@gmail.com> >> >> CONFIG_SYS_INIT_SP_ADDR point the last PHY of IRAM >> and substract the global size. >> >> Signed-off-by: seedshope<bocui107@googlemail.com> > Please fix the From: line in all patches in this set; it should not > appear in the long commit message. ok, I will send RR2. Thanks, seedshope > Amicalement, ^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH 1/3] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared 2011-01-08 15:10 ` seedshope @ 2011-01-08 15:17 ` Albert ARIBAUD 2011-01-09 1:15 ` seedshope 0 siblings, 1 reply; 17+ messages in thread From: Albert ARIBAUD @ 2011-01-08 15:17 UTC (permalink / raw) To: u-boot Le 08/01/2011 16:10, seedshope a ?crit : > On 01/08/2011 01:55 PM, Albert ARIBAUD wrote: >> Le 07/01/2011 16:53, seedshope a ?crit : >>> From: seedshope<bocui107@gmail.com> >>> >>> CONFIG_SYS_INIT_SP_ADDR point the last PHY of IRAM >>> and substract the global size. >>> >>> Signed-off-by: seedshope<bocui107@googlemail.com> >> Please fix the From: line in all patches in this set; it should not >> appear in the long commit message. > ok, I will send RR2. > > Thanks, You're welcome. Don't forget to add some history in V2, so that people can tell what you changed from V1 to V2 of the patch. > seedshope Amicalement, -- Albert. ^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH 1/3] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared 2011-01-08 15:17 ` Albert ARIBAUD @ 2011-01-09 1:15 ` seedshope 0 siblings, 0 replies; 17+ messages in thread From: seedshope @ 2011-01-09 1:15 UTC (permalink / raw) To: u-boot On 01/08/2011 11:17 PM, Albert ARIBAUD wrote: > Le 08/01/2011 16:10, seedshope a ?crit : >> On 01/08/2011 01:55 PM, Albert ARIBAUD wrote: >>> Le 07/01/2011 16:53, seedshope a ?crit : >>>> From: seedshope<bocui107@gmail.com> >>>> >>>> CONFIG_SYS_INIT_SP_ADDR point the last PHY of IRAM >>>> and substract the global size. >>>> >>>> Signed-off-by: seedshope<bocui107@googlemail.com> >>> Please fix the From: line in all patches in this set; it should not >>> appear in the long commit message. >> ok, I will send RR2. >> >> Thanks, > > You're welcome. > > Don't forget to add some history in V2, so that people can tell what > you changed from V1 to V2 of the patch. ok, Thanks, seedshope > >> seedshope > > Amicalement, ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2011-01-09 14:52 UTC | newest] Thread overview: 17+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-01-07 15:53 [U-Boot] [PATCH 1/3] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared seedshope 2011-01-07 15:53 ` [U-Boot] [PATCH 2/3] SMDK6400:use common arm1176 u-boot.lds of cpu layer seedshope 2011-01-08 6:04 ` Albert ARIBAUD 2011-01-08 14:54 ` seedshope 2011-01-07 15:53 ` [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support seedshope 2011-01-08 6:14 ` Albert ARIBAUD 2011-01-08 14:57 ` seedshope 2011-01-08 15:15 ` Minkyu Kang 2011-01-09 1:14 ` seedshope 2011-01-09 7:33 ` Minkyu Kang 2011-01-09 12:27 ` seedshope 2011-01-09 14:12 ` Minkyu Kang 2011-01-09 14:52 ` seedshope 2011-01-08 5:55 ` [U-Boot] [PATCH 1/3] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared Albert ARIBAUD 2011-01-08 15:10 ` seedshope 2011-01-08 15:17 ` Albert ARIBAUD 2011-01-09 1:15 ` seedshope
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox