public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400	nand_spl support
Date: Sat, 08 Jan 2011 07:14:55 +0100	[thread overview]
Message-ID: <4D2800DF.4060704@free.fr> (raw)
In-Reply-To: <1294415633-21029-3-git-send-email-bocui107@gmail.com>

Hi seedshope,

Le 07/01/2011 16:53, seedshope a ?crit :
> From: seedshope<bocui107@gmail.com>
>
> Modify u-boot.lds from nand_spl/board/samsung/smdk6400.

You're also modifying start.S. If you mention files in the patch 
summary, then please mention them all.

> start.o: In function `clbss_l':
> nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to `coloured_LED_init'
> nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to `red_LED_on'
> start.o: In function `_rel_dyn_start_ofs':
> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_start'
> start.o: In function `_rel_dyn_end_ofs':
> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_end'
> start.o: In function `_dynsym_start_ofs':
> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__dynsym_start'
>
> Signed-off-by: seedshope<bocui107@googlemail.com>

Please limit the commit message to a simple explanation of the issue 
fixed, without pasting detailed build messages int it. Here for instance 
you need only indicate that you're removing references to relocation 
symbols and calls to LED functions.

Amicalement,
-- 
Albert.

  reply	other threads:[~2011-01-08  6:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-07 15:53 [U-Boot] [PATCH 1/3] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared seedshope
2011-01-07 15:53 ` [U-Boot] [PATCH 2/3] SMDK6400:use common arm1176 u-boot.lds of cpu layer seedshope
2011-01-08  6:04   ` Albert ARIBAUD
2011-01-08 14:54     ` seedshope
2011-01-07 15:53 ` [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support seedshope
2011-01-08  6:14   ` Albert ARIBAUD [this message]
2011-01-08 14:57     ` seedshope
2011-01-08 15:15   ` Minkyu Kang
2011-01-09  1:14     ` seedshope
2011-01-09  7:33       ` Minkyu Kang
2011-01-09 12:27         ` seedshope
2011-01-09 14:12           ` Minkyu Kang
2011-01-09 14:52             ` seedshope
2011-01-08  5:55 ` [U-Boot] [PATCH 1/3] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undeclared Albert ARIBAUD
2011-01-08 15:10   ` seedshope
2011-01-08 15:17     ` Albert ARIBAUD
2011-01-09  1:15       ` seedshope

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D2800DF.4060704@free.fr \
    --to=albert.aribaud@free.fr \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox