From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Sat, 08 Jan 2011 07:14:55 +0100 Subject: [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support In-Reply-To: <1294415633-21029-3-git-send-email-bocui107@gmail.com> References: <1294415633-21029-1-git-send-email-bocui107@gmail.com> <1294415633-21029-3-git-send-email-bocui107@gmail.com> Message-ID: <4D2800DF.4060704@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi seedshope, Le 07/01/2011 16:53, seedshope a ?crit : > From: seedshope > > Modify u-boot.lds from nand_spl/board/samsung/smdk6400. You're also modifying start.S. If you mention files in the patch summary, then please mention them all. > start.o: In function `clbss_l': > nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to `coloured_LED_init' > nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to `red_LED_on' > start.o: In function `_rel_dyn_start_ofs': > nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_start' > start.o: In function `_rel_dyn_end_ofs': > nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_end' > start.o: In function `_dynsym_start_ofs': > nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__dynsym_start' > > Signed-off-by: seedshope Please limit the commit message to a simple explanation of the issue fixed, without pasting detailed build messages int it. Here for instance you need only indicate that you're removing references to relocation symbols and calls to LED functions. Amicalement, -- Albert.