[U-Boot] [PATCH 7/8] armv7: adapt omap3 to the new cache maintenance framework

Wolfgang Denk
2011-01-17T21:55:11Z

Dear Aneesh V,

In message <4D2B1A90.9030109@ti.com> you wrote:
>
> >> +struct __attribute__ ((__packed__)) emu_hal_params {
> >> + u32 num_params;
> >> + u32 param1;
> >> +};
> >
> > Why exactly do we need the "__attribute__ ((__packed__))" here?
>
> Because a pointer to it has to be passed to ROM code and ROM code
> wouldn't expect any padding.

But padding would only be needed if there were any alignment
requirements requiring it. There are none here.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The combination of a number of things to make existence worthwhile."
"Yes, the philosophy of 'none,' meaning 'all.'"
-- Spock and Lincoln, "The Savage Curtain", stardate 5906.4