From mboxrd@z Thu Jan 1 00:00:00 1970 From: seedshope Date: Sun, 09 Jan 2011 09:14:07 +0800 Subject: [U-Boot] [PATCH 3/3] SMDK6400: Fix build error for smdk6400 nand_spl support In-Reply-To: References: <1294415633-21029-1-git-send-email-bocui107@gmail.com> <1294415633-21029-3-git-send-email-bocui107@gmail.com> Message-ID: <4D290BDF.2070101@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/08/2011 11:15 PM, Minkyu Kang wrote: > Dear seedshope, > > On 8 January 2011 00:53, seedshope wrote: >> From: seedshope >> >> Modify u-boot.lds from nand_spl/board/samsung/smdk6400. >> >> start.o: In function `clbss_l': >> nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to `coloured_LED_init' >> nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to `red_LED_on' >> start.o: In function `_rel_dyn_start_ofs': >> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_start' >> start.o: In function `_rel_dyn_end_ofs': >> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__rel_dyn_end' >> start.o: In function `_dynsym_start_ofs': >> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to `__dynsym_start' >> >> Signed-off-by: seedshope >> >> diff --git a/arch/arm/cpu/arm1176/start.S b/arch/arm/cpu/arm1176/start.S >> index 237dcfe..bde0357 100644 >> --- a/arch/arm/cpu/arm1176/start.S >> +++ b/arch/arm/cpu/arm1176/start.S >> @@ -353,10 +353,11 @@ clbss_l:str r2, [r0] /* clear loop... */ >> add r0, r0, #4 >> cmp r0, r1 >> bne clbss_l >> - >> +#ifndef CONFIG_NAND_SPL > CONFIG_PRELOADER is better No, The nand_spl support can't find the define of coloured_LED_init and red_LED_on. It is base on the build error: make smdk6400_config make the error information as following: nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to `coloured_LED_init' nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to `red_LED_on' Thanks, seedshope >> bl coloured_LED_init >> bl red_LED_on >> #endif >> +#endif >> >> /* > Thanks > Minkyu Kang