From: Xiangfu Liu <xiangfu@openmobilefree.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 4/7] jz4740 nand driver
Date: Sun, 09 Jan 2011 18:35:56 +0800 [thread overview]
Message-ID: <4D298F8C.2060600@openmobilefree.net> (raw)
In-Reply-To: <20110104201645.GC22641@udp111988uds.am.freescale.net>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 01/05/2011 04:16 AM, Scott Wood wrote:
> On Wed, Dec 08, 2010 at 12:20:46AM -0600, Xiangfu Liu wrote:
>> + writel(readl(EMC_NFECR) & ~EMC_NFECR_ECCE, EMC_NFECR);
>
> readl() and other I/O accessors take pointers, not integer addresses.
Hi Scott
I fixed the others error, only this one I don't know how to do that.
can you point me to some example.
thanks for your emails.
> Use I/O accesors.
> U-Boot coding style prohibits declarations mid-block.
> Line length.
> Please symbolically define what went into that magic number.
>
> -Scott
>
- --
Best Regards
Xiangfu Liu
http://www.openmobilefree.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk0pj4wACgkQRRAEFRxkgLSOgwCfZV/I0kCA+AT9Vu1OlXm3sZdU
9PQAmQGVlXtBePoD3jo0KPympGLKAxu5
=Y7s7
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-01-09 10:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 6:20 [U-Boot] [PATCH v4 0/7] those series patches for add ben nanonote board Xiangfu Liu
2010-12-08 6:20 ` [U-Boot] [PATCH v4 1/7] those files are jz4740 base files Xiangfu Liu
2010-12-08 6:20 ` [U-Boot] [PATCH v4 2/7] this is jz4740 head file Xiangfu Liu
2010-12-08 6:20 ` [U-Boot] [PATCH v4 3/7] jz4740 nand spl files Xiangfu Liu
2010-12-08 6:20 ` [U-Boot] [PATCH v4 4/7] jz4740 nand driver Xiangfu Liu
2010-12-08 6:20 ` [U-Boot] [PATCH v4 5/7] add Ben NanoNote board Xiangfu Liu
2010-12-08 6:20 ` [U-Boot] [PATCH v4 6/7] add entry to MAINTAINERS and boards.cfg Xiangfu Liu
2010-12-08 6:20 ` [U-Boot] [PATCH v4 7/7] modify files for ben nanonote board Xiangfu Liu
2011-01-04 20:16 ` [U-Boot] [PATCH v4 4/7] jz4740 nand driver Scott Wood
2011-01-09 10:35 ` Xiangfu Liu [this message]
2011-01-10 18:33 ` Scott Wood
2011-01-04 20:13 ` [U-Boot] [PATCH v4 3/7] jz4740 nand spl files Scott Wood
2011-01-09 8:44 ` Xiangfu Liu
2010-12-08 15:02 ` [U-Boot] [PATCH v4 0/7] those series patches for add ben nanonote board Xiangfu Liu
2010-12-08 15:44 ` Wolfgang Denk
2010-12-08 15:51 ` Xiangfu Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D298F8C.2060600@openmobilefree.net \
--to=xiangfu@openmobilefree.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox