[U-Boot] [PATCH v3] ARM: Avoid compiler optimization for usages of readb, writeb and friends.

Wolfgang Denk
2011-01-09T22:25:50Z

Dear Dirk Behme,

In message <4D1F1841.5060508@googlemail.com> you wrote:
>
> Do you like to test the patch in the attachment? I named it 'v4'.

Please send patches inline.

> After some thinking and testing, it seems to me that the volatile
> optimization issue this patch shall fix is only with the readx()
> macros. So the idea is to drop all writex() changes done in the v3
> version of this patch. With dropping the writex() changes, we would
> drop all issues we discussed with e.g. the GCC statement-expression
> and the do while workaround, too.

This makes no sense. Even if we experience problems only with read*()
at the moment, we should to the Rigth Thing (TM) and fix both the
read*() and write*() functions.

Please have a look a the patch I just posted,
http://patchwork.ozlabs.org/patch/78056/

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I wish Captain Vimes were here. He wouldn't have known what to do
either, but he's got a much better vocabulary to be baffled in.
- Terry Pratchett, _Guards! Guards!_