From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Holler Date: Tue, 11 Jan 2011 04:53:47 +0100 Subject: [U-Boot] [PATCH v3] ARM: Avoid compiler optimization for usages of readb, writeb and friends. In-Reply-To: <20110110150546.B3CBA150A44@gemini.denx.de> References: <1293015862-3678-1-git-send-email-holler@ahsoftware.de> <4D1F1841.5060508@googlemail.com> <4D1F69E9.9030205@ahsoftware.de> <4D1F7197.6010607@googlemail.com> <4D1F76D7.8060603@ahsoftware.de> <4D1F7EC6.9090607@googlemail.com> <4D2072E6.4030400@ahsoftware.de> <4D207DC1.30402@googlemail.com> <4D20E760.7010605@ahsoftware.de> <4D2B1D75.70809@ahsoftware.de> <20110110150546.B3CBA150A44@gemini.denx.de> Message-ID: <4D2BD44B.7040900@ahsoftware.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 10.01.2011 16:05, schrieb Wolfgang Denk: > Dear Alexander Holler, > > In message<4D2B1D75.70809@ahsoftware.de> you wrote: >> >> Beeing kind of a defensive programmer, I still would prefer to use have >> that __asm__ for write* too. That would at least prevent us from a >> possible bug there too. > > So why don't you simply test and, assuming it's working, ACK the patch > I submitted yesterday? We should be on the safe side, then, and don't > have to care about which mood the current compiler's optimizer might > be in or what the POM is. Sorry, I haven't had your last patch (mail) before I've written the mail you are referencing. I have updated my mail-system at home (armv5 with 128mb ram) and the incoming queue, mainly filled through lkml, is still not completly processed. ~2000 messages (3 days) need some time to go through spamassassin on such a low-level hardware. ;) I've seen you've switched from do {} while() to "something else", but I can't comment on that "something else". Because I've already switched to 4.5.2. I'll have to dig out a system where I have a 4.5.1 to test the problem occured with the write. If anybody else already has tested it, I'm fine with it. Regards, Alexander