From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Wed, 12 Jan 2011 16:10:42 +0300
Subject: [U-Boot] [PATCH 15/28] Blackfin: fix bd_t handling
In-Reply-To: <201101101931.23412.vapier@gentoo.org>
References: <1293425300-27644-1-git-send-email-vapier@gentoo.org>
	<201012271142.17334.vapier@gentoo.org>
	<20110110222823.776D4150A4A@gemini.denx.de>
	<201101101931.23412.vapier@gentoo.org>
Message-ID: <4D2DA852.1000401@mvista.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 11.01.2011 3:31, Mike Frysinger wrote:

>>> it isnt a problem to have the parens, and it keeps things sane if someone
>>> does something like:
>>> #define CONFIG_SYS_BD_INFO_ADDR   SOME_DEFINE + 0x1000

>> This would be a violation of basic rules of defensive coding.

>> Please drop these parens.

> i dont see how these two statements are compatible.  defensive coding would
> mean i keep the parens.

    I think Wolfgang meant that defining a macro without parens would be a 
violation -- which should be fixed, not worked around.

> -mike

WBR, Sergei