public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: seedshope <bocui107@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [V2 patch 4/4] SMDK6400: Fix SMDK6400 SDRAM init
Date: Wed, 12 Jan 2011 22:52:48 +0800	[thread overview]
Message-ID: <4D2DC040.7040303@gmail.com> (raw)
In-Reply-To: <4D2D8BA2.9030309@mvista.com>

On 01/12/2011 07:08 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 11-01-2011 17:52, seedshope wrote:
>
>> Since SDRAM init function have already change, So the SDRAM
>> initial function must be change.
>
>> Signed-off-by: seedshope<bocui107@gmail.com>
>
>> diff --git a/board/samsung/smdk6400/smdk6400.c 
>> b/board/samsung/smdk6400/smdk6400.c
>> index 35aa40b..52b44a8 100644
>> --- a/board/samsung/smdk6400/smdk6400.c
>> +++ b/board/samsung/smdk6400/smdk6400.c
>> @@ -78,10 +78,18 @@ int board_init(void)
>> return 0;
>> }
>>
>> -int dram_init(void)
>> +void dram_init_banksize(void)
>> {
>> + DECLARE_GLOBAL_DATA_PTR;
>> +
>> gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
>> gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
>> +}
>> +
>> +int dram_init(void)
>> +{
>> + gd->ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
>> + CONFIG_MAX_RAM_BANK_SIZE);
>
> Please indent that line more to the right, preferrebly start it under 
> '(volatile long *)'.
ok, But I don't know how number tab indent is appropriate. May be the 
effect as following?
gd->ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
CONFIG_MAX_RAM_BANK_SIZE);

Thanks?
seedshope

>
> WBR, Sergei

  reply	other threads:[~2011-01-12 14:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-11 14:52 [U-Boot] RR v2 PATCH: SMDK6400 Fix some build bug seedshope
2011-01-11 14:52 ` [U-Boot] [V2 patch 1/4] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undefined seedshope
2011-01-11 14:52 ` [U-Boot] [V2 patch 2/4] SMDK6400: Fix some label undefined in build error seedshope
2011-01-11 14:52 ` [U-Boot] [V2 patch 3/4] SMDK6400: Fix build error for nand_spl support seedshope
2011-01-18 21:56   ` Wolfgang Denk
2011-01-19 14:08     ` seedshope
2011-01-11 14:52 ` [U-Boot] [V2 patch 4/4] SMDK6400: Fix SMDK6400 SDRAM init seedshope
2011-01-12 11:08   ` Sergei Shtylyov
2011-01-12 14:52     ` seedshope [this message]
2011-01-12 16:35       ` Wolfgang Denk
2011-01-13 11:04       ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D2DC040.7040303@gmail.com \
    --to=bocui107@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox