From: Alexander Holler <holler@ahsoftware.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] ARM: Avoid compiler optimization for readb, writeb and friends.
Date: Wed, 12 Jan 2011 17:49:44 +0100 [thread overview]
Message-ID: <4D2DDBA8.5060404@ahsoftware.de> (raw)
In-Reply-To: <20110112164045.526EACEFAB6@gemini.denx.de>
Am 12.01.2011 17:40, schrieb Wolfgang Denk:
> Dear Alexander Holler,
>
> In message<4D2DCB18.20409@ahsoftware.de> you wrote:
>> Am 09.01.2011 23:19, schrieb Wolfgang Denk:
>>
>>> gcc 4.5.1 seems to ignore (at least some) volatile definitions,
>>> avoid that as done in the kernel.
>>
>> Have had a look at the asm generated by gcc 4.5.1, looks good.
>>
>> The wrong optimization in arch/arm/cpu/armv7/omap3/clock.c is gone and
>> the writeb in drivers/mtd/nand/omap_gpmc.c doesn't have the problem as
>> the v1-patch.
>
> Thanks - but please send a formal Acked-by: and/or Tested-by: .
Oh, as I'm still listed as the author, I thought that isn't necessary.
I don't know if I should paste the whole patch (this is my first ack ;)
), but here are both:
Acked-by: Alexander Holler <holler@ahsoftware.de>
Tested-by: Alexander Holler <holler@ahsoftware.de>
Regards,
Alexander
next prev parent reply other threads:[~2011-01-12 16:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-22 11:04 [U-Boot] [PATCH v3] ARM: Avoid compiler optimization for usages of readb, writeb and friends Alexander Holler
2010-12-22 14:50 ` Dirk Behme
2010-12-22 15:07 ` Alexander Holler
2011-01-01 12:04 ` Dirk Behme
2011-01-01 17:52 ` Alexander Holler
2011-01-01 18:25 ` Dirk Behme
2011-01-01 18:47 ` Alexander Holler
2011-01-01 19:21 ` Dirk Behme
2011-01-02 12:43 ` Alexander Holler
2011-01-02 13:29 ` Dirk Behme
2011-01-02 21:00 ` Alexander Holler
2011-01-10 14:53 ` Alexander Holler
2011-01-10 15:05 ` Wolfgang Denk
2011-01-11 3:53 ` Alexander Holler
2011-01-09 22:25 ` Wolfgang Denk
2011-01-10 16:13 ` Dirk Behme
2011-01-17 21:59 ` Wolfgang Denk
2011-01-09 22:19 ` [U-Boot] [PATCH v4] ARM: Avoid compiler optimization for " Wolfgang Denk
2011-01-12 15:17 ` Thomas Weber
2011-01-12 15:39 ` Alexander Holler
2011-01-12 16:40 ` Wolfgang Denk
2011-01-12 16:49 ` Alexander Holler [this message]
2011-01-15 13:13 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2DDBA8.5060404@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox