[U-Boot] [PATCH 7/8] armv7: adapt omap3 to the new cache maintenance framework

Aneesh V
2011-01-18T05:31:57Z

Dear Wolfgang,

On Tuesday 18 January 2011 03:25 AM, Wolfgang Denk wrote:
> Dear Aneesh V,
>
> In message<4D2B1A90.9030109@ti.com> you wrote:
>>
>>>> +struct __attribute__ ((__packed__)) emu_hal_params {
>>>> + u32 num_params;
>>>> + u32 param1;
>>>> +};
>>>
>>> Why exactly do we need the "__attribute__ ((__packed__))" here?
>>
>> Because a pointer to it has to be passed to ROM code and ROM code
>> wouldn't expect any padding.
>
> But padding would only be needed if there were any alignment
> requirements requiring it. There are none here.

Yes. But, is that guaranteed? I didn't want to make it compiler
dependent. Isn't it safer to use '__attribute__ ((__packed__))'

Best regards,
Aneesh