From: seedshope <bocui107@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [v3 patch 2/4] SMDK6400: Fix some label undefined in build error
Date: Fri, 14 Jan 2011 23:45:36 +0800 [thread overview]
Message-ID: <4D306FA0.50407@gmail.com> (raw)
In-Reply-To: <4D2F3F67.5030603@free.fr>
On 01/14/2011 02:07 AM, Albert ARIBAUD wrote:
> Le 13/01/2011 14:36, seedshope a ?crit :
>> Modify Makefile for cpu_init.c and Start.s use some label,this defined
>> u-boot.lds of arch/arm/cpu/arm1176. But SMDK6400 use the link script
>> board/samsung/smdk6400/u-boot-nand.lds. So add some label form
>> u-boot.lds
>> to u-boot-nand.lds
>>
>> Signed-off-by: seedshope<bocui107@gmail.com>
>>
>> diff --git a/arch/arm/cpu/arm1176/s3c64xx/Makefile
>> b/arch/arm/cpu/arm1176/s3c64xx/Makefile
>> index 0785b19..f4b9574 100644
>> --- a/arch/arm/cpu/arm1176/s3c64xx/Makefile
>> +++ b/arch/arm/cpu/arm1176/s3c64xx/Makefile
>> @@ -30,12 +30,15 @@ LIB = $(obj)lib$(SOC).o
>>
>> SOBJS = reset.o
>>
>> -COBJS-$(CONFIG_S3C6400) += cpu_init.o speed.o
>> +COBJS-$(CONFIG_S3C6400) += speed.o
>> COBJS-y += timer.o
>>
>> +CPUINIT = cpu_init.o
>> +
>> OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS-y))
>> +CPUINIT := $(addprefix $(obj),$(CPUINIT))
>>
>> -all: $(obj).depend $(START) $(LIB)
>> +all: $(obj).depend $(START) $(LIB) $(CPUINIT)
>>
>> $(LIB): $(OBJS)
>> $(call cmd_link_o_target, $(OBJS))
>
> Not sure I get what's the problem and how exactly this changes solves
> it. Can you detail this particular issue?
The issue is mem_ctrl_asm_init redefine in
arch/arm/cpu/arm1176/s3c64xx/cpu_init.s.
At first, the link script file include cpu_init.s in
board/samsung/smd6400/u-boot-nand.s, If I separate the cpu_init.o from
COBJS-$(CONFIG_S3C6400), I guess cmd_link_o_target will deal with
cpu_init.o. So the link script will double link the cpu_init file.
I have two method to solve it.
first: see the patch
second: Modify the link script
But I feel, the first method is safe.
I asked a question. I will RR on next, The patch1 and patch3 have
already ok, Do I only send patch2 and patch4?
>
> Amicalement,
next prev parent reply other threads:[~2011-01-14 15:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 13:36 [U-Boot] RR v3 PATCH: SMDK6400 Fix some build bug seedshope
2011-01-13 13:36 ` [U-Boot] [v3 patch 1/4] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undefined seedshope
2011-01-13 13:36 ` [U-Boot] [v3 patch 2/4] SMDK6400: Fix some label undefined in build error seedshope
2011-01-13 18:07 ` Albert ARIBAUD
2011-01-14 15:45 ` seedshope [this message]
2011-01-14 15:59 ` seedshope
2011-01-14 16:39 ` Albert ARIBAUD
2011-01-14 16:56 ` seedshope
2011-01-14 18:15 ` Albert ARIBAUD
2011-01-14 18:45 ` seedshope
2011-01-19 14:25 ` seedshope
2011-01-13 13:36 ` [U-Boot] [v3 patch 3/4] SMDK6400: Fix build error for nand_spl support seedshope
2011-01-13 13:36 ` [U-Boot] [v3 patch 4/4] SMDK6400: Fix SMDK6400 SDRAM init seedshope
2011-01-14 0:53 ` Minkyu Kang
2011-01-14 15:51 ` seedshope
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D306FA0.50407@gmail.com \
--to=bocui107@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox