From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Chou <thomas@wytron.com.tw>
Date: Tue, 18 Jan 2011 10:05:51 +0800
Subject: [U-Boot] [PATCH] nios2: reset cfi flash before reading env
In-Reply-To: <20110117210220.CB2EDD1CAD5@gemini.denx.de>
References: <1294211855-18584-1-git-send-email-thomas@wytron.com.tw>
	<20110105081529.C430ED31214@gemini.denx.de>
	<4D252AAB.6040308@wytron.com.tw>
	<20110117210220.CB2EDD1CAD5@gemini.denx.de>
Message-ID: <4D34F57F.5040406@wytron.com.tw>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang,

On 01/18/2011 05:02 AM, Wolfgang Denk wrote:
>> void __flash_cmd_reset(flash_info_t *info)
>
> I recommend you have a second, closer look. Notice that
> flash_cmd_reset() comes with __attribute__ weak, because it does not
> work as a general solution - it may work here, but other code may be
> needed on other flash chips.
>
> Your code does not provide such an option.

Thanks a lot. I will add a weak attribute.

Best regards,
Thomas