public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] spi: add support SuperH SPI module
Date: Tue, 18 Jan 2011 16:40:51 +0900	[thread overview]
Message-ID: <4D354403.10606@renesas.com> (raw)
In-Reply-To: <AANLkTinAEJh73Q3_gxdcOZOs1V0hkgLGGOA=AwiDe7d8@mail.gmail.com>

Hi, Iwamatsu-san,

Thank you for your review.

2011/01/17 19:28, Nobuhiro Iwamatsu wrote:
> Hi, Shioda-san.
> 
> 2011/1/17 Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>:
>> +#define SPI_TBR                0x00
>> +#define SPI_RBR                0x00
>> +#define SPI_CR1                0x08
>> +#define SPI_CR2                0x10
>> +#define SPI_CR3                0x18
>> +#define SPI_CR4                0x20
< snip >
> Please add prefix of  "SH_".
Yes, I will add it.

>> +int  spi_cs_is_valid(unsigned int bus, unsigned int cs)
>> +{
>> +       return 1;
>> +}
> 
> Why does this function return "1" every time?
Oh, it's temporary code. I will fix this function.

Best regards,
Yoshihiro Shimoda

  reply	other threads:[~2011-01-18  7:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-17  4:07 [U-Boot] [PATCH] spi: add support SuperH SPI module Yoshihiro Shimoda
2011-01-17 10:28 ` Nobuhiro Iwamatsu
2011-01-18  7:40   ` Yoshihiro Shimoda [this message]
2011-01-18  9:28 ` Wolfgang Denk
2011-01-19  8:16   ` Yoshihiro Shimoda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D354403.10606@renesas.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox