From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] net: sh_eth: add support for SH7757's ETHER
Date: Tue, 18 Jan 2011 16:44:52 +0900 [thread overview]
Message-ID: <4D3544F4.9050607@renesas.com> (raw)
In-Reply-To: <20110117105934.GA13819@chimagu.nigauri.org>
Hi, Iwamatsu-san,
2011/01/17 19:59, Nobuhiro Iwamatsu wrote:
> Hi, Shimoda-san.
>
> On Mon, Jan 17, 2011 at 01:09:23PM +0900, Yoshihiro Shimoda wrote:
< snip >
>> + val = 0x0;
>
> Is this change necessary?
Oh, this is not necessary.
>> /* Check if full duplex mode is supported by the phy */
>> if (phy_status & (PHY_S_100X_F|PHY_S_10T_F)) {
>> printf("Full\n");
>> - outl((ECMR_CHG_DM|ECMR_RE|ECMR_TE|ECMR_DM), ECMR(port));
>> + outl(val | (ECMR_CHG_DM|ECMR_RE|ECMR_TE|ECMR_DM), ECMR(port));
>> } else {
>> printf("Half\n");
>> - outl((ECMR_CHG_DM|ECMR_RE|ECMR_TE), ECMR(port));
>> + outl(val | (ECMR_CHG_DM|ECMR_RE|ECMR_TE), ECMR(port));
>> }
>
> Is this change necessary?
> Because val is changed to 0 at the top, I do not think that this change is necessary.
Thank you for your point.
I will remove it.
Best regards,
Yoshihiro Shimoda
prev parent reply other threads:[~2011-01-18 7:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 4:09 [U-Boot] [PATCH 2/2] net: sh_eth: add support for SH7757's ETHER Yoshihiro Shimoda
2011-01-17 10:59 ` Nobuhiro Iwamatsu
2011-01-18 7:44 ` Yoshihiro Shimoda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3544F4.9050607@renesas.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox