From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Date: Tue, 18 Jan 2011 16:44:52 +0900
Subject: [U-Boot] [PATCH 2/2] net: sh_eth: add support for SH7757's ETHER
In-Reply-To: <20110117105934.GA13819@chimagu.nigauri.org>
References: <4D33C0F3.4020709@renesas.com>
	<20110117105934.GA13819@chimagu.nigauri.org>
Message-ID: <4D3544F4.9050607@renesas.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi, Iwamatsu-san,

2011/01/17 19:59, Nobuhiro Iwamatsu wrote:
> Hi, Shimoda-san.
> 
> On Mon, Jan 17, 2011 at 01:09:23PM +0900, Yoshihiro Shimoda wrote:
< snip >
>> +	val = 0x0;
> 
> Is this change necessary?
Oh, this is not necessary.

>>  	/* Check if full duplex mode is supported by the phy */
>>  	if (phy_status & (PHY_S_100X_F|PHY_S_10T_F)) {
>>  		printf("Full\n");
>> -		outl((ECMR_CHG_DM|ECMR_RE|ECMR_TE|ECMR_DM), ECMR(port));
>> +		outl(val | (ECMR_CHG_DM|ECMR_RE|ECMR_TE|ECMR_DM), ECMR(port));
>>  	} else {
>>  		printf("Half\n");
>> -		outl((ECMR_CHG_DM|ECMR_RE|ECMR_TE),  ECMR(port));
>> +		outl(val | (ECMR_CHG_DM|ECMR_RE|ECMR_TE),  ECMR(port));
>>  	}
> 
> Is this change necessary? 
> Because val is changed to 0 at the top, I do not think that this change is necessary.
Thank you for your point.
I will remove it.

Best regards,
Yoshihiro Shimoda