[U-Boot] [PATCH 1/7] Add support for MX35 processor

Stefano Babic
2011-01-19T11:54:26Z

On 01/19/2011 12:37 PM, Wolfgang Denk wrote:
> No, I wonder why code a loop when a simple memset() does the same.

Ok, I get the point - you are right, I will replace the code with memset.

>
>>> What do these "!<" markers mean?
>>
>> They have no useful meaning and I must drop them.
>
> There are other such cryptic markers - eventually from some doc
> generating tool.

I will check in all patches, and I will remove them.

> Such duplication of information is just a source of errors. And
> asm-offsets.h has been provided exactly for the purpose to avoid such
> #defines. Please use it.

Ok, understood. I will move these defines in asm-offsets.h

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================