From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] MX51EVK: Use SWx macros in PMIC init
Date: Wed, 19 Jan 2011 13:46:13 +0300 [thread overview]
Message-ID: <4D36C0F5.5040000@mvista.com> (raw)
In-Reply-To: <1295379040-11563-2-git-send-email-marek.vasut@gmail.com>
Hello.
On 18-01-2011 22:30, Marek Vasut wrote:
> Signed-off-by: Marek Vasut<marek.vasut@gmail.com>
> diff --git a/board/freescale/mx51evk/mx51evk.c b/board/freescale/mx51evk/mx51evk.c
> index 2160d5a..bcf1934 100644
> --- a/board/freescale/mx51evk/mx51evk.c
> +++ b/board/freescale/mx51evk/mx51evk.c
> @@ -198,17 +198,18 @@ static void power_init(void)
>
> /* Set core voltage to 1.1V */
> val = pmic_reg_read(REG_SW_0);
> - val = (val& (~0x1F)) | 0x14;
> + val = (val& (~SWx_VOLT_MASK)) | SWx_1_100V;
> pmic_reg_write(REG_SW_0, val);
>
> /* Setup VCC (SW2) to 1.25 */
> val = pmic_reg_read(REG_SW_1);
> - val = (val& (~0x1F)) | 0x1A;
> + val = (val& (~SWx_VOLT_MASK)) | SWx_1_250V;
> +
> pmic_reg_write(REG_SW_1, val);
>
> /* Setup 1V2_DIG1 (SW3) to 1.25 */
> val = pmic_reg_read(REG_SW_2);
> - val = (val& (~0x1F)) | 0x1A;
> + val = (val& (~SWx_VOLT_MASK)) | SWx_1_250V;
Could drop the useless parens around ~x, while at it...
WBR, Sergei
next prev parent reply other threads:[~2011-01-19 10:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 19:30 [U-Boot] [PATCH 1/3] MC13892: Add SWx buck switchers definitions Marek Vasut
2011-01-18 19:30 ` [U-Boot] [PATCH 2/3] MX51EVK: Use SWx macros in PMIC init Marek Vasut
2011-01-19 9:12 ` Stefano Babic
2011-01-19 10:46 ` Sergei Shtylyov [this message]
2011-01-18 19:30 ` [U-Boot] [PATCH 3/3 v3] iMX5: EfikaMX: Preliminary board support Marek Vasut
2011-01-19 8:49 ` Wolfgang Denk
2011-01-19 14:36 ` Marek Vasut
2011-01-18 20:57 ` [U-Boot] [PATCH 1/3] MC13892: Add SWx buck switchers definitions Jason Liu
2011-01-19 9:11 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D36C0F5.5040000@mvista.com \
--to=sshtylyov@mvista.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox