From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Wed, 19 Jan 2011 13:46:13 +0300 Subject: [U-Boot] [PATCH 2/3] MX51EVK: Use SWx macros in PMIC init In-Reply-To: <1295379040-11563-2-git-send-email-marek.vasut@gmail.com> References: <1295379040-11563-1-git-send-email-marek.vasut@gmail.com> <1295379040-11563-2-git-send-email-marek.vasut@gmail.com> Message-ID: <4D36C0F5.5040000@mvista.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello. On 18-01-2011 22:30, Marek Vasut wrote: > Signed-off-by: Marek Vasut > diff --git a/board/freescale/mx51evk/mx51evk.c b/board/freescale/mx51evk/mx51evk.c > index 2160d5a..bcf1934 100644 > --- a/board/freescale/mx51evk/mx51evk.c > +++ b/board/freescale/mx51evk/mx51evk.c > @@ -198,17 +198,18 @@ static void power_init(void) > > /* Set core voltage to 1.1V */ > val = pmic_reg_read(REG_SW_0); > - val = (val& (~0x1F)) | 0x14; > + val = (val& (~SWx_VOLT_MASK)) | SWx_1_100V; > pmic_reg_write(REG_SW_0, val); > > /* Setup VCC (SW2) to 1.25 */ > val = pmic_reg_read(REG_SW_1); > - val = (val& (~0x1F)) | 0x1A; > + val = (val& (~SWx_VOLT_MASK)) | SWx_1_250V; > + > pmic_reg_write(REG_SW_1, val); > > /* Setup 1V2_DIG1 (SW3) to 1.25 */ > val = pmic_reg_read(REG_SW_2); > - val = (val& (~0x1F)) | 0x1A; > + val = (val& (~SWx_VOLT_MASK)) | SWx_1_250V; Could drop the useless parens around ~x, while at it... WBR, Sergei