From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Thu, 20 Jan 2011 11:23:03 +0100 Subject: [U-Boot] [PATCH V2 04/11] I2C: mxc_i2c: get rid of __REG access In-Reply-To: <20110120092748.05B9BD301D7@gemini.denx.de> References: <1295513194-16158-1-git-send-email-sbabic@denx.de> <1295513194-16158-5-git-send-email-sbabic@denx.de> <20110120092748.05B9BD301D7@gemini.denx.de> Message-ID: <4D380D07.10107@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/20/2011 10:27 AM, Wolfgang Denk wrote: > Dear Stefano Babic, > > In message <1295513194-16158-5-git-send-email-sbabic@denx.de> you wrote: >> This driver accesses to processor's register >> via __REG macros, that are removed (or are planned >> to be removed) and replaced by C structures. >> This patches replaces all occurrencies of __REG macros. > > Checkpatch says: > > total: 0 errors, 2 warnings, 169 lines checked I have seen, but because __FUNCTION__is generally used, I have not replaced the occurrencies with the suggested __func__. At least, not in this patch. I think it is should be done in a separate patch (I will do in next post). >> @@ -204,7 +219,8 @@ int i2c_read(uchar chip, uint addr, int alen, uchar *buf, int len) >> int i2c_write(uchar chip, uint addr, int alen, uchar *buf, int len) >> { >> int timeout = 10000; >> - DPRINTF("%s chip: 0x%02x addr: 0x%04x alen: %d len: %d\n",__FUNCTION__, chip, addr, alen, len); >> + DPRINTF("%s chip: 0x%02x addr: 0x%04x alen: %d len: %d\n", >> + __FUNCTION__, chip, addr, alen, len); > > While touching this anyway, can we please convert the DPRINTF() into > debug() ? You missed the following patch that removes the ugly private debug functions.. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================