public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v2 1/1] ARM: */start.S: code cleanup
@ 2010-12-23  4:35 Jason Liu
  2011-01-17 19:54 ` Jason Liu
  0 siblings, 1 reply; 4+ messages in thread
From: Jason Liu @ 2010-12-23  4:35 UTC (permalink / raw)
  To: u-boot

Remove the useless code from start.S

Signed-off-by: Jason Liu <r64343@freescale.com>

---
Changes for v2:
-Address the comments from Albert to make changes to all
 ARM cpus with one single patch
---
 arch/arm/cpu/arm1136/start.S   |    2 --
 arch/arm/cpu/arm1176/start.S   |    2 --
 arch/arm/cpu/arm720t/start.S   |    2 --
 arch/arm/cpu/arm920t/start.S   |    2 --
 arch/arm/cpu/arm925t/start.S   |    2 --
 arch/arm/cpu/arm926ejs/start.S |    2 --
 arch/arm/cpu/arm946es/start.S  |    2 --
 arch/arm/cpu/arm_intcm/start.S |    2 --
 arch/arm/cpu/armv7/start.S     |    2 --
 arch/arm/cpu/ixp/start.S       |    2 --
 arch/arm/cpu/lh7a40x/start.S   |    2 --
 arch/arm/cpu/pxa/start.S       |    2 --
 arch/arm/cpu/s3c44b0/start.S   |    2 --
 arch/arm/cpu/sa1100/start.S    |    2 --
 14 files changed, 0 insertions(+), 28 deletions(-)

diff --git a/arch/arm/cpu/arm1136/start.S b/arch/arm/cpu/arm1136/start.S
index 9a6f6cb..b771d31 100644
--- a/arch/arm/cpu/arm1136/start.S
+++ b/arch/arm/cpu/arm1136/start.S
@@ -196,7 +196,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */
 
@@ -251,7 +250,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4
diff --git a/arch/arm/cpu/arm1176/start.S b/arch/arm/cpu/arm1176/start.S
index 237dcfe..363329a 100644
--- a/arch/arm/cpu/arm1176/start.S
+++ b/arch/arm/cpu/arm1176/start.S
@@ -250,7 +250,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */
 
@@ -343,7 +342,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4
diff --git a/arch/arm/cpu/arm720t/start.S b/arch/arm/cpu/arm720t/start.S
index abfa124..c098118 100644
--- a/arch/arm/cpu/arm720t/start.S
+++ b/arch/arm/cpu/arm720t/start.S
@@ -165,7 +165,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */
 
@@ -220,7 +219,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4
diff --git a/arch/arm/cpu/arm920t/start.S b/arch/arm/cpu/arm920t/start.S
index 08f178d..6bccf61 100644
--- a/arch/arm/cpu/arm920t/start.S
+++ b/arch/arm/cpu/arm920t/start.S
@@ -211,7 +211,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */
 
@@ -266,7 +265,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4
diff --git a/arch/arm/cpu/arm925t/start.S b/arch/arm/cpu/arm925t/start.S
index 2c0c869..20ecdd5 100644
--- a/arch/arm/cpu/arm925t/start.S
+++ b/arch/arm/cpu/arm925t/start.S
@@ -202,7 +202,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */
 
@@ -257,7 +256,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4
diff --git a/arch/arm/cpu/arm926ejs/start.S b/arch/arm/cpu/arm926ejs/start.S
index 5519252..eb93ac9 100644
--- a/arch/arm/cpu/arm926ejs/start.S
+++ b/arch/arm/cpu/arm926ejs/start.S
@@ -201,7 +201,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */
 
@@ -256,7 +255,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4
diff --git a/arch/arm/cpu/arm946es/start.S b/arch/arm/cpu/arm946es/start.S
index f9c9470..296effc 100644
--- a/arch/arm/cpu/arm946es/start.S
+++ b/arch/arm/cpu/arm946es/start.S
@@ -173,7 +173,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */
 
@@ -228,7 +227,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4
diff --git a/arch/arm/cpu/arm_intcm/start.S b/arch/arm/cpu/arm_intcm/start.S
index d28e745..e8518e2 100644
--- a/arch/arm/cpu/arm_intcm/start.S
+++ b/arch/arm/cpu/arm_intcm/start.S
@@ -169,7 +169,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */
 
@@ -224,7 +223,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4
diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S
index 684f2d2..cb4f92f 100644
--- a/arch/arm/cpu/armv7/start.S
+++ b/arch/arm/cpu/armv7/start.S
@@ -171,7 +171,6 @@ stack_setup:
 	beq	clear_bss		/* skip relocation */
 #endif
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */
 
@@ -224,7 +223,6 @@ fixnext:
 clear_bss:
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4
diff --git a/arch/arm/cpu/ixp/start.S b/arch/arm/cpu/ixp/start.S
index 9f8c15b..f71a398 100644
--- a/arch/arm/cpu/ixp/start.S
+++ b/arch/arm/cpu/ixp/start.S
@@ -295,7 +295,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */
 
@@ -350,7 +349,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4
diff --git a/arch/arm/cpu/lh7a40x/start.S b/arch/arm/cpu/lh7a40x/start.S
index 32dfe8b..1457427 100644
--- a/arch/arm/cpu/lh7a40x/start.S
+++ b/arch/arm/cpu/lh7a40x/start.S
@@ -182,7 +182,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */
 
@@ -237,7 +236,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4
diff --git a/arch/arm/cpu/pxa/start.S b/arch/arm/cpu/pxa/start.S
index fbd0def..d2d391e 100644
--- a/arch/arm/cpu/pxa/start.S
+++ b/arch/arm/cpu/pxa/start.S
@@ -247,7 +247,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */
 
@@ -304,7 +303,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4
diff --git a/arch/arm/cpu/s3c44b0/start.S b/arch/arm/cpu/s3c44b0/start.S
index 9379af6..9c9c3b3 100644
--- a/arch/arm/cpu/s3c44b0/start.S
+++ b/arch/arm/cpu/s3c44b0/start.S
@@ -154,7 +154,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */
 
@@ -209,7 +208,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4
diff --git a/arch/arm/cpu/sa1100/start.S b/arch/arm/cpu/sa1100/start.S
index 7c2db4f..815d704 100644
--- a/arch/arm/cpu/sa1100/start.S
+++ b/arch/arm/cpu/sa1100/start.S
@@ -158,7 +158,6 @@ stack_setup:
 	cmp	r0, r6
 	beq	clear_bss		/* skip relocation */
 	mov	r1, r6			/* r1 <- scratch for copy_loop */
-	ldr	r2, _TEXT_BASE
 	ldr	r3, _bss_start_ofs
 	add	r2, r0, r3		/* r2 <- source end address	    */
 
@@ -213,7 +212,6 @@ clear_bss:
 #ifndef CONFIG_PRELOADER
 	ldr	r0, _bss_start_ofs
 	ldr	r1, _bss_end_ofs
-	ldr	r3, _TEXT_BASE		/* Text base */
 	mov	r4, r6			/* reloc addr */
 	add	r0, r0, r4
 	add	r1, r1, r4
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v2 1/1] ARM: */start.S: code cleanup
  2010-12-23  4:35 [U-Boot] [PATCH v2 1/1] ARM: */start.S: code cleanup Jason Liu
@ 2011-01-17 19:54 ` Jason Liu
  2011-01-18  7:27   ` Andreas Bießmann
  0 siblings, 1 reply; 4+ messages in thread
From: Jason Liu @ 2011-01-17 19:54 UTC (permalink / raw)
  To: u-boot

Hi, Albert,

2010/12/23 Jason Liu <r64343@freescale.com>:
> Remove the useless code from start.S
>
> Signed-off-by: Jason Liu <r64343@freescale.com>
>
> ---
> Changes for v2:
> -Address the comments from Albert to make changes to all
> ?ARM cpus with one single patch
> ---
> ?arch/arm/cpu/arm1136/start.S ? | ? ?2 --
> ?arch/arm/cpu/arm1176/start.S ? | ? ?2 --
> ?arch/arm/cpu/arm720t/start.S ? | ? ?2 --
> ?arch/arm/cpu/arm920t/start.S ? | ? ?2 --
> ?arch/arm/cpu/arm925t/start.S ? | ? ?2 --
> ?arch/arm/cpu/arm926ejs/start.S | ? ?2 --
> ?arch/arm/cpu/arm946es/start.S ?| ? ?2 --
> ?arch/arm/cpu/arm_intcm/start.S | ? ?2 --
> ?arch/arm/cpu/armv7/start.S ? ? | ? ?2 --
> ?arch/arm/cpu/ixp/start.S ? ? ? | ? ?2 --
> ?arch/arm/cpu/lh7a40x/start.S ? | ? ?2 --
> ?arch/arm/cpu/pxa/start.S ? ? ? | ? ?2 --
> ?arch/arm/cpu/s3c44b0/start.S ? | ? ?2 --
> ?arch/arm/cpu/sa1100/start.S ? ?| ? ?2 --
> ?14 files changed, 0 insertions(+), 28 deletions(-)
>

Any feedback about this patch?

>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v2 1/1] ARM: */start.S: code cleanup
  2011-01-17 19:54 ` Jason Liu
@ 2011-01-18  7:27   ` Andreas Bießmann
  2011-01-20 20:28     ` Albert ARIBAUD
  0 siblings, 1 reply; 4+ messages in thread
From: Andreas Bießmann @ 2011-01-18  7:27 UTC (permalink / raw)
  To: u-boot

Dear Jason Liu,
Dear Albert Aribaud,

Am 17.01.2011 um 20:54 schrieb Jason Liu:

> Hi, Albert,
> 
> 2010/12/23 Jason Liu <r64343@freescale.com>:
>> Remove the useless code from start.S
>> 
>> Signed-off-by: Jason Liu <r64343@freescale.com>
>> 
>> ---
>> Changes for v2:
>> -Address the comments from Albert to make changes to all
>>  ARM cpus with one single patch
>> ---

>>  arch/arm/cpu/arm920t/start.S   |    2 --

> Any feedback about this patch?

Tested-by: Andreas Bie?mann <andreas.devel@googlemail.com>

This patch is correct for arm920t. This patch is most probable correct for other architectures.

regards

Andreas Bie?mann

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v2 1/1] ARM: */start.S: code cleanup
  2011-01-18  7:27   ` Andreas Bießmann
@ 2011-01-20 20:28     ` Albert ARIBAUD
  0 siblings, 0 replies; 4+ messages in thread
From: Albert ARIBAUD @ 2011-01-20 20:28 UTC (permalink / raw)
  To: u-boot

Le 18/01/2011 08:27, Andreas Bie?mann a ?crit :
> Dear Jason Liu,
> Dear Albert Aribaud,
>
> Am 17.01.2011 um 20:54 schrieb Jason Liu:
>
>> Hi, Albert,
>>
>> 2010/12/23 Jason Liu<r64343@freescale.com>:
>>> Remove the useless code from start.S
>>>
>>> Signed-off-by: Jason Liu<r64343@freescale.com>
>>>
>>> ---
>>> Changes for v2:
>>> -Address the comments from Albert to make changes to all
>>>   ARM cpus with one single patch
>>> ---
>
>>>   arch/arm/cpu/arm920t/start.S   |    2 --
>
>> Any feedback about this patch?
>
> Tested-by: Andreas Bie?mann<andreas.devel@googlemail.com>

Applied to u-boot-arm, thanks -- and apologies for the backlogging.

Amicalement,
-- 
Albert.

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-01-20 20:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-23  4:35 [U-Boot] [PATCH v2 1/1] ARM: */start.S: code cleanup Jason Liu
2011-01-17 19:54 ` Jason Liu
2011-01-18  7:27   ` Andreas Bießmann
2011-01-20 20:28     ` Albert ARIBAUD

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox