From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Thu, 20 Jan 2011 21:34:46 +0100 Subject: [U-Boot] [PATCH] arm1136: timer: Replace bss variable by gd In-Reply-To: <4D0DC62C.6000303@denx.de> References: <1291968075-29004-1-git-send-email-hs@denx.de> <4D01E031.3090100@free.fr> <20101217201304.18F3FB19C@gemini.denx.de> <4D0DC62C.6000303@denx.de> Message-ID: <4D389C66.5010509@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le 19/12/2010 09:45, Heiko Schocher a ?crit : > Hello Wolfgang, > > Wolfgang Denk wrote: >> Dear Albert& Heiko, >> >> In message<4D01E031.3090100@free.fr> you wrote: >>>> Reuse the gd->tbl value for timestamp and add gd->lastinc for lastinc bss >>>> values in the arm1136 timer driver for mx31 and omap24xx >>>> >>>> The usage of bss values in drivers before initialisation of bss is forbid> den. >>>> In that special case some data in .rel.dyn gets corrupted. >>>> >>>> This patch is similiar to the patch Dirk Behme posted >>>> for the armv7/omap-common/timer.c >>>> >>>> Tested on the mx31 based qong board >>>> >>>> Signed-off-by: Heiko Schocher >>>> cc: Albert ARIBAUD >>> FWIW, >>> >>> Acked-by: Albert ARIBAUD >> >> Should I pull this into v2010.12, or should we rather wait for amore >> general solution and fix it in the next release? > > I vote for pulling this into the v2010.12 release, beause it is a > bugfix and we get a working code with elf relocation(conceding the > patch is not a perfekt solution, but working) > > bye, > Heiko Applied to u-boot-arm, thanks and apologies for the late action. Amicalement, -- Albert.