[U-Boot] [PATCH] arm1136: timer: Replace bss variable by gd

Heiko Schocher
2010-12-19T08:45:32Z

Hello Wolfgang,

Wolfgang Denk wrote:
> Dear Albert & Heiko,
>
> In message <4D01E031.3090100@free.fr> you wrote:
>>> Reuse the gd->tbl value for timestamp and add gd->lastinc for lastinc bss
>>> values in the arm1136 timer driver for mx31 and omap24xx
>>>
>>> The usage of bss values in drivers before initialisation of bss is forbid> den.
>>> In that special case some data in .rel.dyn gets corrupted.
>>>
>>> This patch is similiar to the patch Dirk Behme posted
>>> for the armv7/omap-common/timer.c
>>>
>>> Tested on the mx31 based qong board
>>>
>>> Signed-off-by: Heiko Schocher<hs@denx.de>
>>> cc: Albert ARIBAUD<albert.aribaud@free.fr>
>> FWIW,
>>
>> Acked-by: Albert ARIBAUD <albert.aribaud@free.fr>
>
> Should I pull this into v2010.12, or should we rather wait for amore
> general solution and fix it in the next release?

I vote for pulling this into the v2010.12 release, beause it is a
bugfix and we get a working code with elf relocation(conceding the
patch is not a perfekt solution, but working)

bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany