From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm926ejs: timer: Replace bss variable by gdr
Date: Fri, 21 Jan 2011 09:33:40 +0100 [thread overview]
Message-ID: <4D3944E4.6090908@denx.de> (raw)
In-Reply-To: <4D389FD9.2000408@free.fr>
Hello Albert,
Albert ARIBAUD wrote:
> Le 20/01/2011 21:43, Albert ARIBAUD a ?crit :
>> Le 10/12/2010 10:33, Heiko Schocher a ?crit :
>>> Reuse the gd->tbl value for timestamp and add gd->lastinc for lastinc bss
>>> values in the arm926ejs timers implementation.
>>>
>>> The usage of bss values in drivers before initialisation of bss is forbidden.
>>> In that special case some data in .rel.dyn gets corrupted.
>>>
>>> This patch is similiar to the patch Dirk Behme posted
>>> for the armv7/omap-common/timer.c and added suggestions
>>> from Reinhard Meyer.
>>>
>>> Tested on the arm926ejs mx27 based magnesium board
>>> Tested on the arm926ejs kirkwood based suen3 board
>>>
>>> Signed-off-by: Heiko Schocher<hs@denx.de>
>>> cc: Albert ARIBAUD<albert.aribaud@free.fr>
>>> cc: Prafulla Wadaskar<prafulla@marvell.com>
>>> cc: Stefano Babic<sbabic@denx.de>
>>> cc: Reinhard Meyer<u-boot@emk-elektronik.de>
>>>
>>> Signed-off-by: Heiko Schocher<hs@denx.de>
>>> ---
>>> arch/arm/cpu/arm926ejs/davinci/timer.c | 6 ++++--
>>> arch/arm/cpu/arm926ejs/kirkwood/timer.c | 6 ++++--
>>> arch/arm/cpu/arm926ejs/mb86r0x/timer.c | 6 ++++--
>>> arch/arm/cpu/arm926ejs/mx25/timer.c | 6 ++++--
>>> arch/arm/cpu/arm926ejs/mx27/timer.c | 6 ++++--
>>> arch/arm/cpu/arm926ejs/omap/timer.c | 6 ++++--
>>> arch/arm/cpu/arm926ejs/orion5x/timer.c | 6 ++++--
>>> arch/arm/cpu/arm926ejs/spear/timer.c | 6 ++++--
>>> arch/arm/cpu/arm926ejs/versatile/timer.c | 6 ++++--
>>> 9 files changed, 36 insertions(+), 18 deletions(-)
[...]
>>> #define TIMER_ENABLE (1<< 7)
>>> #define TIMER_MODE_MSK (1<< 6)
>> Applied to u-boot-arm, with a trivial merge for davinci.
>
> Correction -- can't apply it *and* retain correct authorship in commit.
> Heiko, can you post a rebased version?
Ok, I rebase this patch against current mainline, and send a new
version.
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2011-01-21 8:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 9:33 [U-Boot] [PATCH] arm926ejs: timer: Replace bss variable by gdr Heiko Schocher
2010-12-11 11:41 ` Prafulla Wadaskar
2010-12-13 7:29 ` Stefano Babic
2011-01-20 20:43 ` Albert ARIBAUD
2011-01-20 20:49 ` Albert ARIBAUD
2011-01-21 8:33 ` Heiko Schocher [this message]
2011-01-21 8:48 ` [U-Boot] [PATCH v2] " Heiko Schocher
2011-01-21 8:56 ` [U-Boot] [PATCH v3] " Heiko Schocher
2011-01-21 17:37 ` Albert ARIBAUD
2011-01-22 5:39 ` Alexander Holler
2011-01-22 7:46 ` Albert ARIBAUD
2011-01-22 8:14 ` Reinhard Meyer
2011-01-22 9:21 ` Alexander Holler
2011-01-24 6:42 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3944E4.6090908@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox