From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Fri, 21 Jan 2011 09:33:40 +0100 Subject: [U-Boot] [PATCH] arm926ejs: timer: Replace bss variable by gdr In-Reply-To: <4D389FD9.2000408@free.fr> References: <1291973587-6718-1-git-send-email-hs@denx.de> <4D389E7C.4050100@free.fr> <4D389FD9.2000408@free.fr> Message-ID: <4D3944E4.6090908@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Albert, Albert ARIBAUD wrote: > Le 20/01/2011 21:43, Albert ARIBAUD a ?crit : >> Le 10/12/2010 10:33, Heiko Schocher a ?crit : >>> Reuse the gd->tbl value for timestamp and add gd->lastinc for lastinc bss >>> values in the arm926ejs timers implementation. >>> >>> The usage of bss values in drivers before initialisation of bss is forbidden. >>> In that special case some data in .rel.dyn gets corrupted. >>> >>> This patch is similiar to the patch Dirk Behme posted >>> for the armv7/omap-common/timer.c and added suggestions >>> from Reinhard Meyer. >>> >>> Tested on the arm926ejs mx27 based magnesium board >>> Tested on the arm926ejs kirkwood based suen3 board >>> >>> Signed-off-by: Heiko Schocher >>> cc: Albert ARIBAUD >>> cc: Prafulla Wadaskar >>> cc: Stefano Babic >>> cc: Reinhard Meyer >>> >>> Signed-off-by: Heiko Schocher >>> --- >>> arch/arm/cpu/arm926ejs/davinci/timer.c | 6 ++++-- >>> arch/arm/cpu/arm926ejs/kirkwood/timer.c | 6 ++++-- >>> arch/arm/cpu/arm926ejs/mb86r0x/timer.c | 6 ++++-- >>> arch/arm/cpu/arm926ejs/mx25/timer.c | 6 ++++-- >>> arch/arm/cpu/arm926ejs/mx27/timer.c | 6 ++++-- >>> arch/arm/cpu/arm926ejs/omap/timer.c | 6 ++++-- >>> arch/arm/cpu/arm926ejs/orion5x/timer.c | 6 ++++-- >>> arch/arm/cpu/arm926ejs/spear/timer.c | 6 ++++-- >>> arch/arm/cpu/arm926ejs/versatile/timer.c | 6 ++++-- >>> 9 files changed, 36 insertions(+), 18 deletions(-) [...] >>> #define TIMER_ENABLE (1<< 7) >>> #define TIMER_MODE_MSK (1<< 6) >> Applied to u-boot-arm, with a trivial merge for davinci. > > Correction -- can't apply it *and* retain correct authorship in commit. > Heiko, can you post a rebased version? Ok, I rebase this patch against current mainline, and send a new version. bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany