From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Fri, 21 Jan 2011 20:52:05 +0300
Subject: [U-Boot] [v4 patch 6/6] SMDK6400: Fix SMDK6400 SDRAM init
In-Reply-To: <1295624053-8060-7-git-send-email-bocui107@gmail.com>
References: <1295624053-8060-1-git-send-email-bocui107@gmail.com>
	<1295624053-8060-7-git-send-email-bocui107@gmail.com>
Message-ID: <4D39C7C5.10608@mvista.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello.

seedshope wrote:

> Since SDRAM init function have already change, So the SDRAM
> initial function must be change.

    This description sounds somewhat tautological...

> Signed-off-by: seedshope <bocui107@gmail.com>

    Your real name is required in the signoff.

> ---
>  board/samsung/smdk6400/smdk6400.c |   10 +++++++++-
>  1 files changed, 9 insertions(+), 1 deletions(-)

> diff --git a/board/samsung/smdk6400/smdk6400.c b/board/samsung/smdk6400/smdk6400.c
> index 35aa40b..1d03b7a 100644
> --- a/board/samsung/smdk6400/smdk6400.c
> +++ b/board/samsung/smdk6400/smdk6400.c
> @@ -78,10 +78,18 @@ int board_init(void)
>  	return 0;
>  }
>  
> -int dram_init(void)
> +void dram_init_banksize(void)
>  {
> +	DECLARE_GLOBAL_DATA_PTR;
> +
>  	gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
>  	gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
> +}
> +
> +int dram_init(void)
> +{
> +	gd->ram_size = get_ram_size((long *)CONFIG_SYS_SDRAM_BASE,
> +			PHYS_SDRAM_1_SIZE);

   Could you move this last line more to the right?

WBR, Sergei