public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: seedshope <bocui107@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [v4 patch 6/6] SMDK6400: Fix SMDK6400 SDRAM init
Date: Sat, 22 Jan 2011 02:15:12 +0800	[thread overview]
Message-ID: <4D39CD30.8010102@gmail.com> (raw)
In-Reply-To: <4D39CAF2.8020608@gmail.com>

On 01/22/2011 02:05 AM, seedshope wrote:
> On 01/22/2011 01:52 AM, Sergei Shtylyov wrote:
>> Hello.
>>
>> seedshope wrote:
>>
>>> Since SDRAM init function have already change, So the SDRAM
>>> initial function must be change.
>>
>>    This description sounds somewhat tautological...
> If I describe  as following:
> Since SDRAM init function have already change, Modify SDRAM inital
> function to adapt to it.
>
> How about it?
>>
>>> Signed-off-by: seedshope <bocui107@gmail.com>
>>
>>    Your real name is required in the signoff.
> I use the name for my pen name. It is not problem.
>>
>>> ---
>>>  board/samsung/smdk6400/smdk6400.c |   10 +++++++++-
>>>  1 files changed, 9 insertions(+), 1 deletions(-)
>>
>>> diff --git a/board/samsung/smdk6400/smdk6400.c 
>>> b/board/samsung/smdk6400/smdk6400.c
>>> index 35aa40b..1d03b7a 100644
>>> --- a/board/samsung/smdk6400/smdk6400.c
>>> +++ b/board/samsung/smdk6400/smdk6400.c
>>> @@ -78,10 +78,18 @@ int board_init(void)
>>>      return 0;
>>>  }
>>>
>>> -int dram_init(void)
>>> +void dram_init_banksize(void)
>>>  {
>>> +    DECLARE_GLOBAL_DATA_PTR;
>>> +
>>>      gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
>>>      gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
>>> +}
>>> +
>>> +int dram_init(void)
>>> +{
>>> +    gd->ram_size = get_ram_size((long *)CONFIG_SYS_SDRAM_BASE,
>>> +            PHYS_SDRAM_1_SIZE);
>>
>>   Could you move this last line more to the right?
> Ya, the orig is ok, But I re-do the patch, It is miss. sorry.
Hi Sergei,

I feel this may be you e-mail issue. I open my patch, It is display as 
following:
+         gd->ram_size = get_ram_size((long *)CONFIG_SYS_SDRAM_BASE,
+                                    PHYS_SDRAM_1_SIZE);

Thanks,
seedshope
>
> Thanks
> seedshope
>>
>> WBR, Sergei
>

  reply	other threads:[~2011-01-21 18:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-21 15:34 [U-Boot] v4 patch:SMDK6400: Fix some build bug seedshope
2011-01-21 15:34 ` [U-Boot] [v4 patch 1/6] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undefined seedshope
2011-01-21 20:42   ` Wolfgang Denk
2011-01-22  1:51     ` seedshope
2011-01-21 15:34 ` [U-Boot] [v4 patch 2/6] SMDK6400: Fix some label undefined in build error seedshope
2011-01-21 15:34 ` [U-Boot] [v4 patch 3/6] SMDK6400: Fix the mutiple link error seedshope
2011-01-21 15:34 ` [U-Boot] [v4 patch 4/6] SMDK6400: Add some labels to u-boot.lds to support nand_spl seedshope
2011-01-21 15:34 ` [U-Boot] [v4 patch 5/6] SMDK6400: Disable LED function in start.s on the nand booting seedshope
2011-01-21 15:34 ` [U-Boot] [v4 patch 6/6] SMDK6400: Fix SMDK6400 SDRAM init seedshope
2011-01-21 17:52   ` Sergei Shtylyov
2011-01-21 18:05     ` seedshope
2011-01-21 18:15       ` seedshope [this message]
2011-01-21 18:29         ` Albert ARIBAUD
2011-01-21 18:43           ` seedshope
2011-01-21 19:11             ` Albert ARIBAUD
2011-01-22  1:56               ` seedshope
2011-01-22  7:31                 ` Albert ARIBAUD
2011-01-22 19:23                   ` seedshope
2011-01-22 20:28                     ` Albert ARIBAUD
2011-01-22 20:40                       ` seedshope
2011-01-22 21:30                         ` Wolfgang Denk
2011-01-22 19:29     ` seedshope
2011-01-22  8:26   ` Minkyu Kang
2011-01-22  9:15   ` Thomas Langer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D39CD30.8010102@gmail.com \
    --to=bocui107@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox