From mboxrd@z Thu Jan 1 00:00:00 1970 From: seedshope Date: Sat, 22 Jan 2011 02:15:12 +0800 Subject: [U-Boot] [v4 patch 6/6] SMDK6400: Fix SMDK6400 SDRAM init In-Reply-To: <4D39CAF2.8020608@gmail.com> References: <1295624053-8060-1-git-send-email-bocui107@gmail.com> <1295624053-8060-7-git-send-email-bocui107@gmail.com> <4D39C7C5.10608@mvista.com> <4D39CAF2.8020608@gmail.com> Message-ID: <4D39CD30.8010102@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/22/2011 02:05 AM, seedshope wrote: > On 01/22/2011 01:52 AM, Sergei Shtylyov wrote: >> Hello. >> >> seedshope wrote: >> >>> Since SDRAM init function have already change, So the SDRAM >>> initial function must be change. >> >> This description sounds somewhat tautological... > If I describe as following: > Since SDRAM init function have already change, Modify SDRAM inital > function to adapt to it. > > How about it? >> >>> Signed-off-by: seedshope >> >> Your real name is required in the signoff. > I use the name for my pen name. It is not problem. >> >>> --- >>> board/samsung/smdk6400/smdk6400.c | 10 +++++++++- >>> 1 files changed, 9 insertions(+), 1 deletions(-) >> >>> diff --git a/board/samsung/smdk6400/smdk6400.c >>> b/board/samsung/smdk6400/smdk6400.c >>> index 35aa40b..1d03b7a 100644 >>> --- a/board/samsung/smdk6400/smdk6400.c >>> +++ b/board/samsung/smdk6400/smdk6400.c >>> @@ -78,10 +78,18 @@ int board_init(void) >>> return 0; >>> } >>> >>> -int dram_init(void) >>> +void dram_init_banksize(void) >>> { >>> + DECLARE_GLOBAL_DATA_PTR; >>> + >>> gd->bd->bi_dram[0].start = PHYS_SDRAM_1; >>> gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE; >>> +} >>> + >>> +int dram_init(void) >>> +{ >>> + gd->ram_size = get_ram_size((long *)CONFIG_SYS_SDRAM_BASE, >>> + PHYS_SDRAM_1_SIZE); >> >> Could you move this last line more to the right? > Ya, the orig is ok, But I re-do the patch, It is miss. sorry. Hi Sergei, I feel this may be you e-mail issue. I open my patch, It is display as following: + gd->ram_size = get_ram_size((long *)CONFIG_SYS_SDRAM_BASE, + PHYS_SDRAM_1_SIZE); Thanks, seedshope > > Thanks > seedshope >> >> WBR, Sergei >