From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Fri, 21 Jan 2011 19:29:50 +0100 Subject: [U-Boot] [v4 patch 6/6] SMDK6400: Fix SMDK6400 SDRAM init In-Reply-To: <4D39CD30.8010102@gmail.com> References: <1295624053-8060-1-git-send-email-bocui107@gmail.com> <1295624053-8060-7-git-send-email-bocui107@gmail.com> <4D39C7C5.10608@mvista.com> <4D39CAF2.8020608@gmail.com> <4D39CD30.8010102@gmail.com> Message-ID: <4D39D09E.6070808@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le 21/01/2011 19:15, seedshope a ?crit : > On 01/22/2011 02:05 AM, seedshope wrote: >> On 01/22/2011 01:52 AM, Sergei Shtylyov wrote: >>> Hello. >>> >>> seedshope wrote: >>> >>>> Since SDRAM init function have already change, So the SDRAM >>>> initial function must be change. >>> >>> This description sounds somewhat tautological... >> If I describe as following: >> Since SDRAM init function have already change, Modify SDRAM inital >> function to adapt to it. >> >> How about it? Still unclear, due to the fact you're using the same three terms ("init/initial, RAM, function") for two apparently different things. >>>> Signed-off-by: seedshope >>> >>> Your real name is required in the signoff. >> I use the name for my pen name. It is not problem. I think Sergei means pen names should not be used. I won't personally pass judgment, but so far I've always seen contributors using their actual names. > I feel this may be you e-mail issue. I open my patch, It is display as > following: > > + gd->ram_size = get_ram_size((long *)CONFIG_SYS_SDRAM_BASE, > + PHYS_SDRAM_1_SIZE); Your patch, pulled from patchwork and viewed in vi, has three tabs on that second line, which does not align properly. You should check your code editor settings re: tabs. Amicalement, -- Albert.