From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexander Holler <holler@ahsoftware.de>
Date: Sat, 22 Jan 2011 06:39:39 +0100
Subject: [U-Boot] [PATCH v3] arm926ejs: timer: Replace bss variable by
 gdr
In-Reply-To: <1295600199-3461-1-git-send-email-hs@denx.de>
References: <1291973587-6718-1-git-send-email-hs@denx.de>
	<1295600199-3461-1-git-send-email-hs@denx.de>
Message-ID: <4D3A6D9B.8020503@ahsoftware.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello,

Am 21.01.2011 09:56, schrieb Heiko Schocher:

> -static ulong timestamp;
> -static ulong lastdec;
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +#define timestamp gd->tbl
> +#define lastdec gd->lastinc

I'm the only one who doesn't like such defines? They might be handy for 
quick fixes, but in regard to style and readablity I don't like them. 
When looking at teh code where they will used, you won't see the actual 
place where they are stored. And in more complex expression they might 
become dangerous to use because they hide the operator "->".

Regards,

Alexander