public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: seedshope <bocui107@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [v4 patch 6/6] SMDK6400: Fix SMDK6400 SDRAM init
Date: Sun, 23 Jan 2011 03:23:44 +0800	[thread overview]
Message-ID: <4D3B2EC0.1020102@gmail.com> (raw)
In-Reply-To: <4D3A87D6.80803@free.fr>

On 01/22/2011 03:31 PM, Albert ARIBAUD wrote:
> Hi seedshope,
>
> Le 22/01/2011 02:56, seedshope a ?crit :
>
>>>> My patch is ok, I just two tabs in my e-mail, But I sent the mail,
>>>> It is change.
>>> Do you send the patch through git format-patch and git send-email?
>
>> Yes, I use the git format-patch and git send-email
>
>>> Many e-mail softwares have weird issues when posting git patches,
>>> which is why git has its own tools for sending patches via e-mail.
>
>> ok
>
> Since you're using git format-patch and git send-email, then your 
> original change is not correctly aligned. I suggest you check your 
> code editor's settings on indentation and use of tabulations, notably 
> the "tab size": tabs should align on 8-space multiples; also check 
> that your editor uses a fixed font -- you never know.
Hi Amicalement

I check my patch 6 on the 
http://news.gmane.org/gmane.comp.boot-loaders.u-boot, It look fine.
I have a bit despondent. Why do you think it has a format problem.

Thanks
seedshope
>
> Amicalement,

  reply	other threads:[~2011-01-22 19:23 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-21 15:34 [U-Boot] v4 patch:SMDK6400: Fix some build bug seedshope
2011-01-21 15:34 ` [U-Boot] [v4 patch 1/6] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undefined seedshope
2011-01-21 20:42   ` Wolfgang Denk
2011-01-22  1:51     ` seedshope
2011-01-21 15:34 ` [U-Boot] [v4 patch 2/6] SMDK6400: Fix some label undefined in build error seedshope
2011-01-21 15:34 ` [U-Boot] [v4 patch 3/6] SMDK6400: Fix the mutiple link error seedshope
2011-01-21 15:34 ` [U-Boot] [v4 patch 4/6] SMDK6400: Add some labels to u-boot.lds to support nand_spl seedshope
2011-01-21 15:34 ` [U-Boot] [v4 patch 5/6] SMDK6400: Disable LED function in start.s on the nand booting seedshope
2011-01-21 15:34 ` [U-Boot] [v4 patch 6/6] SMDK6400: Fix SMDK6400 SDRAM init seedshope
2011-01-21 17:52   ` Sergei Shtylyov
2011-01-21 18:05     ` seedshope
2011-01-21 18:15       ` seedshope
2011-01-21 18:29         ` Albert ARIBAUD
2011-01-21 18:43           ` seedshope
2011-01-21 19:11             ` Albert ARIBAUD
2011-01-22  1:56               ` seedshope
2011-01-22  7:31                 ` Albert ARIBAUD
2011-01-22 19:23                   ` seedshope [this message]
2011-01-22 20:28                     ` Albert ARIBAUD
2011-01-22 20:40                       ` seedshope
2011-01-22 21:30                         ` Wolfgang Denk
2011-01-22 19:29     ` seedshope
2011-01-22  8:26   ` Minkyu Kang
2011-01-22  9:15   ` Thomas Langer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D3B2EC0.1020102@gmail.com \
    --to=bocui107@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox