From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Rapoport <mike@compulab.co.il>
Date: Thu, 27 Jan 2011 09:54:43 +0200
Subject: [U-Boot] [PATCH V5 2/4] serial: Add Tegra2 serial port support
In-Reply-To: <1296057514.15489.2057.camel@petert>
References: <1295651217-32421-1-git-send-email-twarren@nvidia.com>	
	<1295651217-32421-3-git-send-email-twarren@nvidia.com>	
	<4D3E85BD.4060201@compulab.co.il>	
	<AANLkTimCpSHkkjCGP391S9+=q90m=t=L7RF1aqsJfyc7@mail.gmail.com>	
	<4D3F3CA0.3080909@compulab.co.il>	
	<AANLkTinr_wZNKu3cfQSazypfxuxX=mfTMmY0q7JKbE5h@mail.gmail.com>	
	<AANLkTim5Jpjj_U9Hoct+fiGC4r6b58Rs-aHUhM01xOES@mail.gmail.com>	
	<1295994280.15489.34.camel@petert>
	<4D3FD7AD.4040005@compulab.co.il>
	<1296057514.15489.2057.camel@petert>
Message-ID: <4D4124C3.6020806@compulab.co.il>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 01/26/11 17:58, Peter Tyser wrote:
> On Wed, 2011-01-26 at 10:13 +0200, Mike Rapoport wrote:
>> On 01/26/11 00:24, Peter Tyser wrote:
> 
>> Moreover, I'd prefer to see pinmux_board_init or something similar that
>> configures all the pins at once rather than collection of pinmux_init_uart,
>> pinmux_init_sdmmc, pinmux_init_gmi etc that will grow as more drivers are added.
> 
> I can see that point but its a different discussion.  I don't know
> enough about the Tegra2 to comment on this, but it seems like a good
> idea based on previous experiences with boards with similar pinmuxing
> (eg mpc8260).  In my last email I mentioned a table-driven approach
> (similar to the mpc8260 implementation?) which sounds somewhat like
> you're proposing.

Yes, I was thinking about table-driven approach, though slightly more
complicated than in mpc8260 :)
I think we can mostly reuse the Linux implementation of Tegra2 pinmux (1 and 2):
However, the pinmuxing API can be added after the basic Tegra2 support is
merged, IMO.

(1)
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=arch/arm/mach-tegra/pinmux.c;h=f80d507671bc1b22921ab2821c8a2cde427f1b5f;hb=HEAD
(2)
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=arch/arm/mach-tegra/pinmux-t2-tables.c;h=a6ea34e782dc339091b49e54871f953048651ad3;hb=HEAD


> Best,
> Peter
> 


-- 
Sincerely yours,
Mike.