From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V7 1/5] mv: seperate kirkwood and armada from common setting
Date: Fri, 28 Jan 2011 08:27:47 +0100 [thread overview]
Message-ID: <4D426FF3.6040502@free.fr> (raw)
In-Reply-To: <AANLkTi=N7N0tREfn8A005hbiTvt6-m6vVGSXx+aoSJDh@mail.gmail.com>
Le 28/01/2011 07:59, Lei Wen a ?crit :
> Hi Albert,
>
> On Fri, Jan 28, 2011 at 2:47 PM, Albert ARIBAUD<albert.aribaud@free.fr> wrote:
>> Hi Lei,
>>
>> Le 28/01/2011 02:28, Lei Wen a ?crit :
>>
>>>>> diff --git a/arch/arm/include/asm/arch-kirkwood/config.h
>>>>> b/arch/arm/include/asm/arch-kirkwood/config.h
>>>>> new file mode 100644
>>>>> index 0000000..7c6d63b
>>>>> --- /dev/null
>>>>> +++ b/arch/arm/include/asm/arch-kirkwood/config.h
>>>>> @@ -0,0 +1,145 @@
>>
>> ...
>>
>>>>> +#ifndef CONFIG_SYS_KWD_CONFIG
>>>>> +#define CONFIG_SYS_KWD_CONFIG
>>>>> $(SRCTREE)/$(CONFIG_BOARDDIR)/kwbimage.cfg
>>>>
>>>> What are the '$()' operators doing here ?
>>>
>>> This definition is served as generating kirkwood special image, which
>>> I just move it from mv-common.h
>>> $(obj)u-boot.kwb: $(obj)u-boot.bin
>>> $(obj)tools/mkimage -n $(CONFIG_SYS_KWD_CONFIG) -T
>>> kwbimage \
>>> -a $(CONFIG_SYS_TEXT_BASE) -e $(CONFIG_SYS_TEXT_BASE) -d
>>> $< $@
>>
>> What I would like to understand is, the '$(X)' macro expansion operator
>> indeed has meaning and makes sense for some tools such as Make, but not for
>> a C preprocessor or compiler. Is this config.h file included by a makefile
>> somehow?
>>
>
> Yes, it would be included by the makefile as below:
> Makefile: line 471:
> $(obj)include/autoconf.mk: $(obj)include/config.h
>
> Take guruplug as example.
> Its guruplug.h would be include in the include/config.h.
> While guruplug would involve the mv-common.h, in which the
> arch/arm/include/asm/arch-kirkwood/config.h would be included.
Understood. Maybe a comment right before the surprising '$()' line
indicating why they're here would avoid other people wondering as I did.
> I know this maybe a little complicated, but that is what it works.
So be it. :)
> Best regards,
> Lei
Amicalement,
--
Albert.
next prev parent reply other threads:[~2011-01-28 7:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 2:40 [U-Boot] [PATCH V6 0/5] Add Pantheon soc and dkb board support Lei Wen
2011-01-25 2:40 ` [U-Boot] [PATCH V6 1/5] mv: seperate kirkwood and armada from common setting Lei Wen
2011-01-25 2:40 ` [U-Boot] [PATCH V6 2/5] ARM: Add Support for Marvell Pantheon Familiy SoCs Lei Wen
2011-01-25 2:40 ` [U-Boot] [PATCH V6 3/5] serial: add pantheon soc support Lei Wen
2011-01-25 2:40 ` [U-Boot] [PATCH V6 4/5] mvmfp: add MFP configuration support for PANTHEON Lei Wen
2011-01-25 2:40 ` [U-Boot] [PATCH V6 5/5] Pantheon: Add Board Support for Marvell dkb board Lei Wen
2011-01-26 10:31 ` [U-Boot] [PATCH V7 0/5] Add Pantheon soc and dkb board support Lei Wen
2011-01-28 9:19 ` [U-Boot] [PATCH V8 " Lei Wen
2011-02-05 6:53 ` Albert ARIBAUD
2011-02-09 9:47 ` Prafulla Wadaskar
2011-01-28 9:19 ` [U-Boot] [PATCH V8 1/5] mv: seperate kirkwood and armada from common setting Lei Wen
2011-01-28 9:19 ` [U-Boot] [PATCH V8 2/5] ARM: Add Support for Marvell Pantheon Familiy SoCs Lei Wen
2011-01-28 9:19 ` [U-Boot] [PATCH V8 3/5] serial: add pantheon soc support Lei Wen
2011-01-28 9:19 ` [U-Boot] [PATCH V8 4/5] mvmfp: add MFP configuration support for PANTHEON Lei Wen
2011-01-28 9:19 ` [U-Boot] [PATCH V8 5/5] Pantheon: Add Board Support for Marvell dkb board Lei Wen
2011-01-26 10:31 ` [U-Boot] [PATCH V7 1/5] mv: seperate kirkwood and armada from common setting Lei Wen
2011-01-27 18:34 ` Albert ARIBAUD
2011-01-28 1:28 ` Lei Wen
2011-01-28 6:47 ` Albert ARIBAUD
2011-01-28 6:59 ` Lei Wen
2011-01-28 7:27 ` Albert ARIBAUD [this message]
2011-01-28 8:17 ` Wolfgang Denk
2011-01-26 10:31 ` [U-Boot] [PATCH V7 2/5] ARM: Add Support for Marvell Pantheon Familiy SoCs Lei Wen
2011-01-26 10:31 ` [U-Boot] [PATCH V7 3/5] serial: add pantheon soc support Lei Wen
2011-01-26 10:31 ` [U-Boot] [PATCH V7 4/5] mvmfp: add MFP configuration support for PANTHEON Lei Wen
2011-01-26 10:31 ` [U-Boot] [PATCH V7 5/5] Pantheon: Add Board Support for Marvell dkb board Lei Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D426FF3.6040502@free.fr \
--to=albert.aribaud@free.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox