[U-Boot] [PATCH V2 05/11] I2C: mxc_i2c: address failure with mx35 processor

Stefano Babic
2011-01-20T10:27:01Z

On 01/20/2011 10:30 AM, Wolfgang Denk wrote:
> Dear Stefano Babic,
>
> In message <1295513194-16158-6-git-send-email-sbabic@denx.de> you wrote:
>> There is sporadic failures when more as one I2C slave
>> is on the bus and the processor tries to communicate
>> with more as one slave.
>> The problem was seen on a mx35pdk (two I2C slaves,
>> PMIC controller and CAN/RTC chip).
>
> Please also mention which approach the patch takes to fix this
> problem.

Ok

>
> Checkpatch says:
>
> total: 1 errors, 1 warnings, 166 lines checked

I know, but I found the construct ok. checkpatch complains against using
assignment in if function, even if it is large used. Again, as we have a
tool to check patches, I will change to remove this issue.

>
> Please have a look.
>
>> -#ifdef DEBUG
>> -#define DPRINTF(args...) printf(args)
>> -#else
>> -#define DPRINTF(args...)
>> -#endif
>
> Ah. Please forget the related comment in my previous message.

...and you please forget my comment to your comment...

>
> But please mention this change in the commit message.

I will do it.

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================