From: Shinya Kuribayashi <skuribay@pobox.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] MIPS: Purple: Fix multiple definition error on final linking of u-boot binary
Date: Sat, 05 Feb 2011 21:11:23 +0900 [thread overview]
Message-ID: <4D4D3E6B.2040605@pobox.com> (raw)
In-Reply-To: <1296734392-15203-3-git-send-email-daniel.schwierzeck@googlemail.com>
On 02/03/2011 08:59 PM, daniel.schwierzeck at googlemail.com wrote:
> The linker of recent toolchains complains about multiple definitions
> on final linking of u-boot binary. This patch removes all redundant
> object files from u-boot.lds those are already added to .text section
> by the linker.
Confirmed.
> That patch could not be tested but the resulting u-boot.map still looks
> good. The start symbol is at 0xB0000000, the environment at 0xB0008000
> so u-boot should boot.
Agreed.
> --- a/board/purple/u-boot.lds
> +++ b/board/purple/u-boot.lds
> @@ -36,11 +36,6 @@ SECTIONS
> {
> arch/mips/cpu/start.o (.text)
> board/purple/lowlevel_init.o (.text)
> - arch/mips/cpu/cache.o (.text)
> - common/main.o (.text)
> - common/dlmalloc.o (.text)
> - common/cmd_boot.o (.text)
> - lib/zlib.o (.text)
> . = DEFINED(env_offset) ? env_offset : .;
> common/env_embedded.o (.ppcenv)
This is ok, though we have some room for further cealnups. With having
.text statement in the lowlevel_init.S, we could remove all these lines.
Applied anyway, thanks for the patch.
next prev parent reply other threads:[~2011-02-05 12:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 11:59 [U-Boot] [PATCH 0/3] MIPS: Fix failed run of MAKEALL mips script daniel.schwierzeck at googlemail.com
2011-02-03 11:59 ` [U-Boot] [PATCH 1/3] MIPS: VCT: Fix enabling of unwanted options if networking or USB support are disabled daniel.schwierzeck at googlemail.com
2011-02-03 12:12 ` Stefan Roese
2011-02-03 12:31 ` Daniel Schwierzeck
2011-02-03 11:59 ` [U-Boot] [PATCH 2/3] MIPS: Purple: Fix multiple definition error on final linking of u-boot binary daniel.schwierzeck at googlemail.com
2011-02-05 12:11 ` Shinya Kuribayashi [this message]
2011-02-05 14:15 ` Wolfgang Denk
2011-02-03 11:59 ` [U-Boot] [PATCH 3/3] MIPS: dbau1x00: Disable compilation of flash driver stub daniel.schwierzeck at googlemail.com
2011-02-03 12:14 ` Stefan Roese
2011-02-03 12:36 ` Daniel Schwierzeck
2011-02-03 13:35 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4D3E6B.2040605@pobox.com \
--to=skuribay@pobox.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox