From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aneesh V Date: Fri, 11 Feb 2011 16:21:43 +0530 Subject: [U-Boot] [RFC] ARM: mx31pdk: Use the new relocation scheme In-Reply-To: <4D51AC9C.8040908@free.fr> References: <1294836544-24512-1-git-send-email-fabio.estevam@freescale.com> <4D2F004B.9090204@denx.de> <4D309716.4000905@freescale.com> <4D4E8E11.2010906@gmail.com> <4D4FD850.3050800@freescale.com> <4D4FFE09.2090709@denx.de> <4D504CAA.7000302@gmail.com> <4D5178DA.4050401@freescale.com> <4D518280.3010300@denx.de> <4D5198EA.7020703@gmail.com> <4D51A52C.8080002@denx.de> <4D51AC9C.8040908@free.fr> Message-ID: <4D5514BF.2080906@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Albert, On Wednesday 09 February 2011 02:20 AM, Albert ARIBAUD wrote: > Le 08/02/2011 21:18, stefano babic a ?crit : >> Am 08.02.2011 20:26, schrieb Magnus Lilja: >>> Patch reposted as a separate mail a couple of minutes ago. >>> >>> As I mention in the patch I think Fabio's patch has to be applied first. >> >> I think your patch is ok - Fabio fixed the syntax error as you do. We >> need only one of them. >> >>> Another solution would be to change my patch somewhat to apply it first >>> and then update Fabios patch to only touch the i.MX31-PDK specific >>> files. >> >> IMHO this is the preferred way, because the two issues are orthogonal. >> Your patch fixes booting from NAND for ARM11, and Fabio's patch fix the >> mx31pdk board only. > > Agreed. > > Note also that there was a recent patch to ARM926's start.S (replacing > 'adr r1, _start' with 'ldr r1, _TEXT_BASE' at line 284). The same should > be done on arm1136. Is this going to happen for armv7 too? What is the real reason behind this proposal. What is the case when _start is not same as _TEXT_BASE(I looked at the archives but couldn't filter out the original discussion on this) I see a problem with that. _TEXT_BASE is based on CONFIG_SYS_TEXT_BASE. In our SPL's case CONFIG_SYS_TEXT_BASE indicates the TEXT_BASE for u-boot and *CONFIG_SYS_SPL_TEXT_BASE* indicates the TEXT_BASE for SPL. Both are defined and useful in SPL because one is used for linking SPL while the other is used while loading u-boot from MMC. So, CONFIG_SYS_TEXT_BASE used in the start.S of SPL will not be correct. In the worst case we need to define yet another label in the linker scripts like __text_base. But I was wondering if we could maintain the status quo for armv7: that is 'adr r1, _start' Best regards, Aneesh