[U-Boot] [PATCH v2] mkimage: add "-V" option to print version information

Albert ARIBAUD
2011-02-11T21:55:06Z

Wolfgang,

Please ignore my previous post on V1, I had not seen V2. My comment
holds, though:

Le 11/02/2011 13:22, Wolfgang Denk a ?crit :
> Signed-off-by: Wolfgang Denk<wd@denx.de>
> ---
> v2: fix missing argument to printf() call.
>
> tools/mkimage.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/tools/mkimage.c b/tools/mkimage.c
> index f5859d7..127be57 100644
> --- a/tools/mkimage.c
> +++ b/tools/mkimage.c
> @@ -23,6 +23,7 @@
>
> #include "mkimage.h"
> #include<image.h>
> +#include<version.h>
>
> static void copy_file(int, const char *, int);
> static void usage(void);
> @@ -246,6 +247,10 @@ main (int argc, char **argv)
> case 'v':
> params.vflag++;
> break;
> + case 'V':
> + printf("mkimage version %s\n",
> + U_BOOT_VERSION + 7);

If that magic number 7 (and the addition, as well) has any reason, it
should at least be explained in a short comment.

> + exit(EXIT_SUCCESS);
> case 'x':
> params.xflag++;
> break;
> @@ -590,6 +595,8 @@ usage ()
> params.cmdname);
> fprintf (stderr, " %s [-D dtc_options] -f fit-image.its fit-image\n",
> params.cmdname);
> + fprintf (stderr, " %s -V ==> print version information and exit\n",
> + params.cmdname);
>
> exit (EXIT_FAILURE);
> }

Amicalement,
--
Albert.