[U-Boot] [PATCH v3] mkimage: add "-V" option to print version information

Wolfgang Denk
2011-02-12T09:37:16Z

Dear Kim Phillips,

In message <20110211171117.b9b05b01.kim.phillips@freescale.com> you wrote:
> On Fri, 11 Feb 2011 23:41:43 +0100
> Wolfgang Denk <wd@denx.de> wrote:
>
> > + case 'V':
> > + /*
> > + * Skip the "U-Boot " part in
> > + * U_BOOT_VERSION by adding 7
> > + */
> > + printf("mkimage version %s\n",
> > + U_BOOT_VERSION + 7);
>
> I'd have done it without magic nor comments as
>
> U_BOOT_VERSION[sizeof("U-Boot ") + 1]
>
> or even
>
> U_BOOT_VERSION[strlen("U-Boot ")]

Hm... I would have cleaned up such locations in U-Boot as part of my
v4 patch that introduces PLAIN_VERSION - if I had found any such
code. Am I missing something?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I haven't lost my mind - it's backed up on tape somewhere."