From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.aribaud@free.fr>
Date: Fri, 11 Feb 2011 23:31:37 +0100
Subject: [U-Boot] [PATCH] ARM: fix write*() I/O accessors
In-Reply-To: <1297463148-6612-1-git-send-email-wd@denx.de>
References: <1297463148-6612-1-git-send-email-wd@denx.de>
Message-ID: <4D55B8C9.8070605@free.fr>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Le 11/02/2011 23:25, Wolfgang Denk a ?crit :
> Commit 3c0659b "ARM: Avoid compiler optimization for readb, writeb
> and friends." introduced I/O accessors with memory barriers.
> Unfortunately the new write*() accessors introduced a bug:
>
> The problem is that the argument "v" gets evaluated twice.  This
> breaks code like used here (from "drivers/net/dnet.c"):
>
> 	for (i = 0; i<  wrsz; i++)
> 		writel(*bufp++,&dnet->regs->TX_DATA_FIFO);
>
> Use auxiliary variables to avoid such problems.
>
> Signed-off-by: Wolfgang Denk<wd@denx.de>
> Cc: Albert Aribaud<albert.aribaud@free.fr>
> Cc: Alexander Holler<holler@ahsoftware.de>
> Cc: Dirk Behme<dirk.behme@googlemail.com>
> ---
>
> This patch fixes a pretty nasty problem.  Everybody who has
> experienced strange failures on ARM lately should apply it ASAP and
> re-test.  As far as I can tell at least the following drivers are
> affected:
>
> drivers/net/dnet.c:		writel(*bufp++,&dnet->regs->TX_DATA_FIFO);
> drivers/usb/musb/musb_core.c:	writeb(*data++,&musbr->fifox[ep]);
> drivers/mmc/pxa_mmc.c:		writel(*src++, MMC_TXFIFO);
> drivers/mmc/mxcmmc.c:		writel(*buf++,&host->base->buffer_access);
> drivers/spi/davinci_spi.c:	writel(data1_reg_val | *txp++,&ds->regs->dat1);
>
> Albert, please apply ASAP!

Applied, available on u-boot-arm/master.

Amicalement,
-- 
Albert.