public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC][PATCH] ARMV7: Patch to fix hard float build issues
Date: Fri, 18 Feb 2011 18:01:55 +0100	[thread overview]
Message-ID: <4D5EA603.8010402@free.fr> (raw)
In-Reply-To: <1298042212-12260-1-git-send-email-raghuveer.murthy@ti.com>

Le 18/02/2011 16:16, Raghuveer Murthy a ?crit :
> U-boot built for MeeGo on PandaBoard, with compiler option
> -mfloat-abi=hard, caused a build break. Please refer to the bug id:
>
> http://bugs.meego.com/show_bug.cgi?id=13140

Is this the official U-Boot? Why is it still at 2010.09 ?

> Removing the -msoft-float options in the config.mk files, allowed it
> to be built for both armv7hl and armv7el compilers on MeeGo
>
> Please refer to the below link for more details:
> http://wiki.meego.com/SDK/Toolchains/ToolchainChangeProposal
>
> Signed-off-by: Raghuveer Murthy<raghuveer.murthy@ti.com>

I would like to know which board of mainline U-boot is affected by the 
issue and how I can reproduce it on u-boot[-arm]/master.

However, I can already tell that this 'bug' can only occur upon a mix of 
object files compiled with -msoft-float and -mhard-float; which means 
some files were compiled with -mhard-float; and this should not happen 
at all, since U-Boot should not use any floats at all, so:

- either some files in the case reported were compiled voluntarily with 
hard-float, and this is not a generally supported use case of U-Boot;

- or they were compiled without any float option and the toolchain 
defaulted to hard-float, which may be a meego but is no reason in itself 
for U-Boot to adapt to it.

My feeling at the moment is that U-Boot should keep -msoft-float, to be 
sure that any float code present in the code base, if it has to be, will 
run regardless of hw floating point capabilities, because U-Boot 
binaries should make the least possible assumptions on the hardware they 
are running on.

Now, CPUs/SoCs/boards that know they have a floating point unit may 
justly want to replace -msoft-float with -mhard-float everywhere 
throughout U-Boot; I would welcome a patch that allows U-Boot to default 
to soft float while allowing CPUs/SoCs/boards to override it for hard float.

In no case, however, should -msoft-float be *removed*: that would make 
float support in U-Boot implicit and dependent on the toolchain in use, 
and I think U-Boot float support should always be explicit and not 
depend on the toolchain.

Amicalement,
-- 
Albert.

  reply	other threads:[~2011-02-18 17:01 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-18 15:16 [U-Boot] [RFC][PATCH] ARMV7: Patch to fix hard float build issues Raghuveer Murthy
2011-02-18 17:01 ` Albert ARIBAUD [this message]
2011-02-18 21:11   ` Alexander Holler
2011-02-19 11:19   ` Måns Rullgård
2011-02-19 13:19     ` Alexander Holler
2011-02-19 13:25       ` Måns Rullgård
2011-02-19 13:51         ` Albert ARIBAUD
2011-02-19 14:06           ` Alexander Holler
2011-02-19 14:27             ` Albert ARIBAUD
2011-02-19 14:34               ` Måns Rullgård
2011-02-19 15:18                 ` Albert ARIBAUD
2011-02-19 18:36                   ` Måns Rullgård
2011-02-19 19:37                 ` Wolfgang Denk
2011-02-19 14:39               ` Alexander Holler
     [not found]                 ` <4D5FE29A.6050609@free.fr>
2011-02-19 15:40                   ` Alexander Holler
2011-02-19 15:59                     ` [U-Boot] reasons for armv5 as default Alexander Holler
2011-02-19 17:48                       ` Albert ARIBAUD
2011-02-20  2:20                         ` Alexander Holler
2011-02-19 19:46                       ` Wolfgang Denk
2011-02-19 19:39                     ` [U-Boot] [RFC][PATCH] ARMV7: Patch to fix hard float build issues Wolfgang Denk
2011-02-19 19:33             ` Wolfgang Denk
2011-02-19 19:32           ` Wolfgang Denk
2011-02-19 19:26         ` Wolfgang Denk
2011-02-18 22:41 ` Wolfgang Denk
2011-02-19 19:55 ` Wolfgang Denk
2011-02-21 10:36   ` Raghuveer Murthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5EA603.8010402@free.fr \
    --to=albert.aribaud@free.fr \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox